Uh oh!
There was an error while loading. Please reload this page.
Remove code used to support h5py<2.10.0 - #7334
Merged
Merged
Conversation
It seems that the relevant issue was fixed in 2.10.0 h5py/h5py@466181b I'm not sure how far back you want to fix things. I'm hoping to test this on the CI. I found this since I've been auditing slowdowns in our codebase, which has caused me to review much of the reading pipeline.
dcherian
commented
Nov 29, 2022
Contributor
I think this is good. It seems like |
hmaarrfk
marked this pull request as ready for review
November 29, 2022 20:23
dcherian added a commit
to dcherian/xarray
that referenced
this pull request
Dec 2, 2022
* upstream/main: (39 commits) Support the new compression argument in netCDF4 > 1.6.0 (pydata#6981) Remove setuptools-scm-git-archive, require setuptools-scm>=7 (pydata#7253) Fix mypy failures (pydata#7343) Docs: add example of writing and reading groups to netcdf (pydata#7338) Reset file pointer to 0 when reading file stream (pydata#7304) Enable mypy warn unused ignores (pydata#7335) Optimize some copying (pydata#7209) Add parse_dims func (pydata#7051) Fix coordinate attr handling in `xr.where(..., keep_attrs=True)` (pydata#7229) Remove code used to support h5py<2.10.0 (pydata#7334) [pre-commit.ci] pre-commit autoupdate (pydata#7330) Fix PR number in what’s new (pydata#7331) Enable `origin` and `offset` arguments in `resample` (pydata#7284) fix doctests: supress urllib3 warning (pydata#7326) fix flake8 config (pydata#7321) implement Zarr v3 spec support (pydata#6475) Fix polyval overloads (pydata#7315) deprecate pynio backend (pydata#7301) mypy - Remove some ignored packages and modules (pydata#7319) Switch to T_DataArray in .coords (pydata#7285) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the relevant issue was fixed in 2.10.0 h5py/h5py@466181b
I'm not sure how far back you want to fix things. I'm hoping to test this on the CI.
I found this since I've been auditing slowdowns in our codebase, which has caused me to review much of the reading pipeline.
Do you want to add a test for h5py>=2.10.0? Or can we assume that users won't install things together.
https://pypi.org/project/h5py/2.10.0/
I could for example set the backend to not be available if a version of h5py that is too old is detected.
One could alternatively, just keep the code here.
whats-new.rstapi.rst