Skip to content

Use map_overlap for rolling reductions with Dask - #9770

Merged
dcherian merged 4 commits into
pydata:mainfrom
phofl:dask-rolling-reducers
Nov 13, 2024
Merged

Use map_overlap for rolling reductions with Dask#9770
dcherian merged 4 commits into
pydata:mainfrom
phofl:dask-rolling-reducers

Conversation

@phofl

Copy link
Copy Markdown
Contributor
  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

This enables Dasks map_overlap for rolling reductions, the previous issues with memory consumption are now handled in map_overlap as far as I can tell

@phofl
phofl marked this pull request as draft November 12, 2024 14:48
@phofl

Copy link
Copy Markdown
ContributorAuthor

Looks like CI is green, anything I should check here?

cc @dcherian FYI

@phofl
phofl marked this pull request as ready for review November 12, 2024 15:11
Comment threadxarray/core/rolling.py
Comment threadxarray/core/dask_array_ops.py Outdated
@dcherian

dcherian commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

I guess this means I can simplify #9720 since we don't need it for the built-in reductions?

@phofl

phofl commented Nov 12, 2024

Copy link
Copy Markdown
ContributorAuthor

I guess this means I can simplify #9720 since we don't need it for the built-in reductions?

unfortunately no, more than one windowing dim takes the construct path :(

@phofl

Copy link
Copy Markdown
ContributorAuthor

The doc build thing is unrelated

@max-sixty

Copy link
Copy Markdown
Collaborator

Looks good!

@max-sixtymax-sixty added the plan to merge Final call for comments label Nov 12, 2024
@dcheriandcherian changed the title Use map_overlap for rolling reducers with DaskUse map_overlap for rolling reductions with DaskNov 13, 2024
@phofl

Copy link
Copy Markdown
ContributorAuthor

Failures seem unrelated

@dcherian
dcherian merged commit b16a104 into pydata:mainNov 13, 2024
@phofl
phofl deleted the dask-rolling-reducers branch November 13, 2024 16:19
@phoflphofl mentioned this pull request Nov 14, 2024
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 16, 2024
* main:
fix cf decoding of grid_mapping (pydata#9765)
Allow wrapping `np.ndarray` subclasses (pydata#9760)
Optimize polyfit (pydata#9766)
Use `map_overlap` for rolling reductions with Dask (pydata#9770)
fix html repr indexes section (pydata#9768)
dcherian added a commit that referenced this pull request Nov 19, 2024
* main: (24 commits)
Bump minimum versions (#9796)
Namespace-aware `xarray.ufuncs` (#9776)
Add prettier and pygrep hooks to pre-commit hooks (#9644)
`rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (#9720)
Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (#9793)
Buffer types (#9787)
Add download stats badges (#9786)
Fix open_mfdataset for list of fsspec files (#9785)
add 'User-Agent'-header to pooch.retrieve (#9782)
Optimize `ffill`, `bfill` with dask when `limit` is specified (#9771)
fix cf decoding of grid_mapping (#9765)
Allow wrapping `np.ndarray` subclasses (#9760)
Optimize polyfit (#9766)
Use `map_overlap` for rolling reductions with Dask (#9770)
fix html repr indexes section (#9768)
Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (#9763)
unpin array-api-strict, as issues are resolved upstream (#9762)
rewrite the `min_deps_check` script (#9754)
CI runs ruff instead of pep8speaks (#9759)
Specify copyright holders in main license file (#9756)
...
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 19, 2024
* main:
Bump minimum versions (pydata#9796)
Namespace-aware `xarray.ufuncs` (pydata#9776)
Add prettier and pygrep hooks to pre-commit hooks (pydata#9644)
`rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (pydata#9720)
Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793)
Buffer types (pydata#9787)
Add download stats badges (pydata#9786)
Fix open_mfdataset for list of fsspec files (pydata#9785)
add 'User-Agent'-header to pooch.retrieve (pydata#9782)
Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771)
fix cf decoding of grid_mapping (pydata#9765)
Allow wrapping `np.ndarray` subclasses (pydata#9760)
Optimize polyfit (pydata#9766)
Use `map_overlap` for rolling reductions with Dask (pydata#9770)
wavebyrd pushed a commit to wavebyrd/xarray that referenced this pull request Mar 13, 2026
* main: (24 commits)
Bump minimum versions (pydata#9796)
Namespace-aware `xarray.ufuncs` (pydata#9776)
Add prettier and pygrep hooks to pre-commit hooks (pydata#9644)
`rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (pydata#9720)
Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793)
Buffer types (pydata#9787)
Add download stats badges (pydata#9786)
Fix open_mfdataset for list of fsspec files (pydata#9785)
add 'User-Agent'-header to pooch.retrieve (pydata#9782)
Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771)
fix cf decoding of grid_mapping (pydata#9765)
Allow wrapping `np.ndarray` subclasses (pydata#9760)
Optimize polyfit (pydata#9766)
Use `map_overlap` for rolling reductions with Dask (pydata#9770)
fix html repr indexes section (pydata#9768)
Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (pydata#9763)
unpin array-api-strict, as issues are resolved upstream (pydata#9762)
rewrite the `min_deps_check` script (pydata#9754)
CI runs ruff instead of pep8speaks (pydata#9759)
Specify copyright holders in main license file (pydata#9756)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan to mergeFinal call for commentstopic-dask

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@phofl@dcherian@max-sixty