Skip to content

add 'User-Agent'-header to pooch.retrieve - #9782

Merged
kmuehlbauer merged 5 commits into
pydata:mainfrom
kmuehlbauer:fix-docs
Nov 15, 2024
Merged

add 'User-Agent'-header to pooch.retrieve#9782
kmuehlbauer merged 5 commits into
pydata:mainfrom
kmuehlbauer:fix-docs

Conversation

@kmuehlbauer

@kmuehlbauerkmuehlbauer commented Nov 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

mathause
mathause reviewed Nov 15, 2024
View reviewed changes

@mathausemathause left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably just leave away the version from the string... & is there a reason you don't pass the downloader directly?

Comment threadxarray/tutorial.py Outdated
Comment threadxarray/tutorial.py Outdated
kmuehlbauerand others added 2 commits November 15, 2024 09:29
@kmuehlbauer@mathause
Apply suggestions from code review
41f310d
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a7b6c57
for more information, see https://pre-commit.ci
@kmuehlbauer

kmuehlbauer commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

& is there a reason you don't pass the downloader directly?

No, I was just somehow following the pooch tutorial 😁

@mathausemathause mentioned this pull request Nov 15, 2024
Merged
4 tasks
@kmuehlbauer

kmuehlbauer commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Can probably just leave away the version from the string.

It might be useful to know the actual version for debugging, but I have no strong opinion.

@mathause

mathause commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

Yes that's also good for me (just thought it's not worth debugging forever)

@kmuehlbauer

kmuehlbauer commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Yes that's also good for me (just thought it's not worth debugging forever)

I was more thinking about situations where users experience these issues again. It might be that one time User-Agent is not enough to add to the headers.

@kmuehlbauer

kmuehlbauer commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

@mathause Thanks for the review. I think this is ready to go.

@kmuehlbauer
kmuehlbauer marked this pull request as ready for review November 15, 2024 08:43
@kmuehlbauerkmuehlbauer added the plan to merge Final call for comments label Nov 15, 2024
@kmuehlbauer

kmuehlbauer commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Maybe I should add a whats-new-entry for more visibility.

mathause
mathause approved these changes Nov 15, 2024
View reviewed changes

@mathausemathause left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast PR!

@kmuehlbauer
kmuehlbauer merged commit 864b35a into pydata:mainNov 15, 2024
@kmuehlbauer
kmuehlbauer deleted the fix-docs branch November 15, 2024 09:28
@keewis

keewis commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

for reference, python-requests (which pooch uses to do the download) adds a User-Agent of python-requests/<version>. My guess is that the combination of RTD servers + python-requests user agent was blocked, which is why changing to something else helps.

dcherian added a commit to dcherian/xarray that referenced this pull request Nov 16, 2024
@dcherian
Merge branch 'main' into custom-groupers
b9507fe
* main:
Add download stats badges (pydata#9786)
Fix open_mfdataset for list of fsspec files (pydata#9785)
add 'User-Agent'-header to pooch.retrieve (pydata#9782)
Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771)
dcherian added a commit that referenced this pull request Nov 19, 2024
@dcherian
Merge branch 'main' into backend-indexing
ab20531
* main: (24 commits)
Bump minimum versions (#9796)
Namespace-aware `xarray.ufuncs` (#9776)
Add prettier and pygrep hooks to pre-commit hooks (#9644)
`rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (#9720)
Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (#9793)
Buffer types (#9787)
Add download stats badges (#9786)
Fix open_mfdataset for list of fsspec files (#9785)
add 'User-Agent'-header to pooch.retrieve (#9782)
Optimize `ffill`, `bfill` with dask when `limit` is specified (#9771)
fix cf decoding of grid_mapping (#9765)
Allow wrapping `np.ndarray` subclasses (#9760)
Optimize polyfit (#9766)
Use `map_overlap` for rolling reductions with Dask (#9770)
fix html repr indexes section (#9768)
Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (#9763)
unpin array-api-strict, as issues are resolved upstream (#9762)
rewrite the `min_deps_check` script (#9754)
CI runs ruff instead of pep8speaks (#9759)
Specify copyright holders in main license file (#9756)
...
dcherian added a commit to dcherian/xarray that referenced this pull request Nov 19, 2024
@dcherian
Merge branch 'main' into groupby-shuffle
d533638
* main:
Bump minimum versions (pydata#9796)
Namespace-aware `xarray.ufuncs` (pydata#9776)
Add prettier and pygrep hooks to pre-commit hooks (pydata#9644)
`rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (pydata#9720)
Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793)
Buffer types (pydata#9787)
Add download stats badges (pydata#9786)
Fix open_mfdataset for list of fsspec files (pydata#9785)
add 'User-Agent'-header to pooch.retrieve (pydata#9782)
Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771)
fix cf decoding of grid_mapping (pydata#9765)
Allow wrapping `np.ndarray` subclasses (pydata#9760)
Optimize polyfit (pydata#9766)
Use `map_overlap` for rolling reductions with Dask (pydata#9770)
wavebyrd pushed a commit to wavebyrd/xarray that referenced this pull request Mar 13, 2026
@dcherian
Merge branch 'main' into backend-indexing
9e96ede
* main: (24 commits)
Bump minimum versions (pydata#9796)
Namespace-aware `xarray.ufuncs` (pydata#9776)
Add prettier and pygrep hooks to pre-commit hooks (pydata#9644)
`rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (pydata#9720)
Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793)
Buffer types (pydata#9787)
Add download stats badges (pydata#9786)
Fix open_mfdataset for list of fsspec files (pydata#9785)
add 'User-Agent'-header to pooch.retrieve (pydata#9782)
Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771)
fix cf decoding of grid_mapping (pydata#9765)
Allow wrapping `np.ndarray` subclasses (pydata#9760)
Optimize polyfit (pydata#9766)
Use `map_overlap` for rolling reductions with Dask (pydata#9770)
fix html repr indexes section (pydata#9768)
Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (pydata#9763)
unpin array-api-strict, as issues are resolved upstream (pydata#9762)
rewrite the `min_deps_check` script (pydata#9754)
CI runs ruff instead of pep8speaks (pydata#9759)
Specify copyright holders in main license file (pydata#9756)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathausemathausemathause approved these changes

Assignees

No one assigned

Labels

plan to mergeFinal call for comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs builds are broken

3 participants

@kmuehlbauer@mathause@keewis