[Bug] Enforce cpus-per-task for SlurmJobExecutor

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jan-janssen]

Summary by CodeRabbit

• Bug Fixes
  • SLURM command generation now explicitly includes a CPU-per-task allocation even for single-thread configurations, ensuring correctly formed scheduler commands and consistent resource requests.
  • Unit tests updated to expect the explicit CPU-per-task flag so test coverage reflects the corrected command behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR broadens SLURM command generation to add --cpus-per-task=<n> when threads_per_core >= 1 and updates two unit tests to expect --cpus-per-task=1.

Changes

SLURM cpus-per-task condition

Layer / File(s)	Summary
Add cpus-per-task when threads_per_core >= 1 src/executorlib/standalone/command.py	The condition that adds --cpus-per-task in generate_slurm_command is changed from threads_per_core > 1 to threads_per_core >= 1.
Update tests to expect --cpus-per-task=1 tests/unit/standalone/interactive/test_backend.py	Two tests (test_command_slurm, test_command_slurm_user_command) are updated to include --cpus-per-task=1 in the expected srun argument lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• pyiron/executorlib#782: Both PRs modify generate_slurm_command's logic for when --cpus-per-task is included.
• pyiron/executorlib#569: Related edits to generate_slurm_command and formatting of --cpus-per-task across interactive/standalone implementations.

Poem

I nibble at code with curious ear,
One thread was missing, now it’s here.
A tiny flag to set things right,
SLURM hums softly through the night.
Hoppy tests pass — what a delight! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately describes the main change: broadening the condition for including --cpus-per-task in SLURM commands from threads_per_core > 1 to threads_per_core >= 1.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch generate_slurm_command

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/executorlib/standalone/command.py`:
- Around line 156-157: Add a regression test that exercises the code path where
threads_per_core == 1 and asserts the generated SLURM/Sbatch command includes
the exact flag "--cpus-per-task=1"; specifically, call the same command-building
function or routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9ba5929-6353-44c4-9020-c2f4fdb7e452

📥 Commits

Reviewing files that changed from the base of the PR and between d93553b and 51be895.

📒 Files selected for processing (1)

• src/executorlib/standalone/command.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for threads_per_core == 1.

This behavior change is not locked by the shown test coverage (only threads_per_core=2 is asserted), so a dedicated assertion for --cpus-per-task=1 would prevent regressions on this exact condition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/executorlib/standalone/command.py` around lines 156 - 157, Add a
regression test that exercises the code path where threads_per_core == 1 and
asserts the generated SLURM/Sbatch command includes the exact flag
"--cpus-per-task=1"; specifically, call the same command-building function or
routine that produces command_prepend_lst (the code in
src/executorlib/standalone/command.py that checks threads_per_core and appends
"--cpus-per-task=") with threads_per_core=1 and assert the resulting command
list/string contains "--cpus-per-task=1" to prevent regressions (place this
alongside the existing tests that cover threads_per_core=2).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (ca348e6) to head (33d67e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1002 +/- ##
=======================================
Coverage 94.19% 94.19% =======================================
Files 39 39 Lines 2103 2103 =======================================
Hits 1981 1981 Misses 122 122 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.