Uh oh!
There was an error while loading. Please reload this page.
[bug] SLURM: Fix CPUs per task - #569
Conversation
WalkthroughThe pull request modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Job Executor
participant CmdGen as generate_slurm_command
Caller->>CmdGen: Request command generation (threads_per_core > 1)
CmdGen->>CmdGen: Concatenate "--cpus-per-task=" with the thread count
CmdGen-->>Caller: Return updated command list
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #569 +/- ##
==========================================
+ Coverage 95.73% 95.89% +0.15%
==========================================
Files 26 26 Lines 1149 1168 +19 ==========================================
+ Hits 1100 1120 +20 + Misses 49 48 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/test_pysqa_subprocess.py (1)
48-59: Consider adding more test cases.The test effectively validates the SLURM command generation with
threads_per_core=2, confirming the correct formatting of--cpus-per-task=2. However, consider adding test cases for:
threads_per_core=1to verify behavior when equal sign isn't needed- Edge cases like
threads_per_core=0orNone- Use a more portable path instead of hardcoding "/tmp/test"
Here's a suggested implementation:
deftest_generate_slurm_command_cases(self): test_cases= [ { 'input': {'cores': 1, 'cwd': '.', 'threads_per_core': 2}, 'expected': ['srun', '-n', '1', '-D', '.', '--cpus-per-task=2'] }, { 'input': {'cores': 1, 'cwd': '.', 'threads_per_core': 1}, 'expected': ['srun', '-n', '1', '-D', '.', '--cpus-per-task', '1'] }, { 'input': {'cores': 1, 'cwd': '.'}, # default case'expected': ['srun', '-n', '1', '-D', '.'] } ] forcaseintest_cases: withself.subTest(threads_per_core=case['input'].get('threads_per_core')): command_lst=generate_slurm_command(**case['input']) self.assertEqual(command_lst, case['expected'])
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/test_pysqa_subprocess.py(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: unittest_win
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
🔇 Additional comments (1)
tests/test_pysqa_subprocess.py (1)
2-2: LGTM!The import statement is correctly placed and specifically imports the function being tested.
Summary by CodeRabbit
Bug Fixes
Tests