Skip to content

Learner1D type hints and add typeguard to pytest tests - #325

Merged
basnijholt merged 5 commits into
masterfrom
learner1d-type-hints
Aug 30, 2021
Merged

Learner1D type hints and add typeguard to pytest tests#325
basnijholt merged 5 commits into
masterfrom
learner1d-type-hints

Conversation

@basnijholt

@basnijholtbasnijholt commented Aug 28, 2021

Copy link
Copy Markdown
Member

Description

I am splitting up #244 into smaller parts.

Since it has been ready for review for almost 2 years but no-one has looked at it, I will go ahead and auto-complete this as soon as the typeguard and mypy issues have been solved.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholtbasnijholt changed the title Learner1d type hintsLearner1D type hintsAug 28, 2021
@basnijholt
basnijholtforce-pushed the learner1d-type-hints branch 2 times, most recently from 1d2496f to 3d359c3CompareAugust 28, 2021 12:42
@codecov-commenter

codecov-commenter commented Aug 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #325 (087a00f) into master (c820704) will increase coverage by 0.04%.
The diff coverage is 97.46%.

Impacted file tree graph

@@ Coverage Diff @@## master #325 +/- ##
==========================================
+ Coverage 80.72% 80.77% +0.04% 
==========================================
Files 38 38 Lines 5018 5045 +27 Branches 918 918 ==========================================
+ Hits 4051 4075 +24 - Misses 822 824 +2 - Partials 145 146 +1 
Impacted FilesCoverage Δ
adaptive/learner/learner1D.py90.15% <97.22%> (+0.41%)⬆️
adaptive/learner/average_learner1D.py78.88% <100.00%> (-0.75%)⬇️
adaptive/learner/base_learner.py84.09% <100.00%> (ø)
adaptive/tests/test_learners.py98.83% <100.00%> (+<0.01%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c820704...087a00f. Read the comment docs.

@basnijholtbasnijholt changed the title Learner1D type hintsLearner1D type hints and add typeguard to pytest testsAug 30, 2021
@basnijholt
basnijholt merged commit 7f76093 into masterAug 30, 2021
@basnijholt
basnijholt deleted the learner1d-type-hints branch August 30, 2021 12:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@basnijholt@codecov-commenter@akhmerov