Skip to content

Add type annotations - #244

Closed
basnijholt wants to merge 21 commits into
mainfrom
mypy
Closed

Add type annotations#244
basnijholt wants to merge 21 commits into
mainfrom
mypy

Conversation

@basnijholt

@basnijholtbasnijholt commented Dec 15, 2019

Copy link
Copy Markdown
Member

I have used MonkeyType when running the tests that automatically added the type hints.

Then I went over all the changes and fixed (or simplified) the things.

@basnijholt
basnijholtforce-pushed the mypy branch 9 times, most recently from cdf369d to 54a6726CompareDecember 15, 2019 18:18
@basnijholtbasnijholt changed the title WIP: Add type annotationsAdd type annotationsDec 15, 2019
Comment threadadaptive/learner/learnerND.py Outdated
@basnijholt
basnijholtforce-pushed the mypy branch 3 times, most recently from e959e8c to 91c1ebdCompareDecember 15, 2019 22:01
@basnijholt

Copy link
Copy Markdown
MemberAuthor

@akhmerov and @jbweston, I am done with this.

The only thing that has room for improvement, is the loss functions of the LearnerND. However, since we might deprecate that code, I didn't invest too much time.

@codecov-io

codecov-io commented Dec 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #244 into master will increase coverage by 0.22%.
The diff coverage is 96.48%.

Impacted file tree graph

@@ Coverage Diff @@## master #244 +/- ##
==========================================
+ Coverage 79.52% 79.74% +0.22% 
==========================================
Files 32 32 Lines 4401 4469 +68 Branches 810 810 ==========================================
+ Hits 3500 3564 +64 - Misses 776 778 +2 - Partials 125 127 +2
Impacted FilesCoverage Δ
adaptive/_version.py48.14% <100%> (+0.48%)⬆️
adaptive/learner/skopt_learner.py59.7% <100%> (+1.23%)⬆️
adaptive/learner/learner1D.py91.89% <100%> (-0.44%)⬇️
adaptive/learner/learner2D.py78.49% <100%> (+0.1%)⬆️
adaptive/utils.py83.05% <100%> (+0.59%)⬆️
adaptive/learner/triangulation.py85.2% <100%> (+0.31%)⬆️
adaptive/learner/balancing_learner.py74.46% <100%> (+0.69%)⬆️
adaptive/learner/data_saver.py88.88% <100%> (+0.65%)⬆️
adaptive/learner/integrator_learner.py88.17% <100%> (+0.23%)⬆️
adaptive/learner/integrator_coeffs.py95.34% <100%> (+0.05%)⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfeb5ef...100f289. Read the comment docs.

@basnijholt
basnijholtforce-pushed the mypy branch 5 times, most recently from 30cded3 to 614f599CompareDecember 20, 2019 17:27
@jbweston
jbweston self-requested a review April 28, 2020 20:00
@jbweston

Copy link
Copy Markdown
Contributor

I've put this on my review backlog

@basnijholt

Copy link
Copy Markdown
MemberAuthor

Closing.

This is superseded by #370, #371, #372, #373, #374, #375, #376, #377, #378, and #379.

@basnijholt
basnijholt deleted the mypy branch October 12, 2022 22:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@basnijholt@codecov-io@jbweston