Skip to content

Add type-hints to Runner - #370

Merged
basnijholt merged 6 commits into
mainfrom
type-hint-runner
Nov 28, 2022
Merged

Add type-hints to Runner#370
basnijholt merged 6 commits into
mainfrom
type-hint-runner

Conversation

@basnijholt

@basnijholtbasnijholt commented Oct 12, 2022

Copy link
Copy Markdown
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt
basnijholtforce-pushed the type-hint-runner branch 2 times, most recently from 95cc29b to 50143e5CompareOctober 12, 2022 04:06
@basnijholtbasnijholt changed the title Type hint runnerType-hint RunnerOct 12, 2022
@basnijholtbasnijholt changed the title Type-hint RunnerAdd type-hints to RunnerOct 12, 2022
@codecov-commenter

codecov-commenter commented Oct 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #370 (cb77432) into main (28d4c35) will increase coverage by 0.05%.
The diff coverage is 88.73%.

@@ Coverage Diff @@## main #370 +/- ##
==========================================
+ Coverage 77.88% 77.94% +0.05% 
==========================================
Files 37 37 Lines 5508 5526 +18 Branches 989 989 ==========================================
+ Hits 4290 4307 +17 - Misses 1066 1067 +1 
Partials 152 152 
Impacted FilesCoverage Δ
adaptive/utils.py61.20% <84.61%> (+2.95%)⬆️
adaptive/runner.py68.89% <89.65%> (+0.16%)⬆️
adaptive/learner/average_learner1D.py74.75% <0.00%> (+0.66%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholtbasnijholt mentioned this pull request Oct 12, 2022
@basnijholt
basnijholt merged commit fad189e into mainNov 28, 2022
@basnijholt
basnijholt deleted the type-hint-runner branch November 28, 2022 18:12
basnijholt added a commit that referenced this pull request Dec 2, 2022
* Add type-annotations to Runner
* Add more type-hints
* Redo typing of ExecutorTypes and FutureTypes
* move around functions
* do not import from _asyncio
basnijholt added a commit that referenced this pull request Apr 7, 2023
* Add type-annotations to Runner
* Add more type-hints
* Redo typing of ExecutorTypes and FutureTypes
* move around functions
* do not import from _asyncio
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@basnijholt@codecov-commenter