Skip to content

Add type-hints to BalancingLearner - #371

Merged
basnijholt merged 1 commit into
mainfrom
type-hint-balancing-learner
Oct 12, 2022
Merged

Add type-hints to BalancingLearner#371
basnijholt merged 1 commit into
mainfrom
type-hint-balancing-learner

Conversation

@basnijholt

Copy link
Copy Markdown
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholtbasnijholt changed the title Add type-hints to adaptive/learner/balancing_learner.pyAdd type-hints to BalancingLearnerOct 12, 2022
@basnijholt
basnijholt enabled auto-merge (squash) October 12, 2022 04:35
@basnijholt
basnijholtforce-pushed the type-hint-balancing-learner branch from 87961cd to afc2b5fCompareOctober 12, 2022 04:40
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #371 (afc2b5f) into main (1b7e84d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #371 +/- ##
==========================================
- Coverage 77.67% 77.65% -0.03% 
==========================================
Files 37 37 Lines 5393 5401 +8 Branches 981 981 ==========================================
+ Hits 4189 4194 +5 - Misses 1058 1059 +1 - Partials 146 148 +2 
Impacted FilesCoverage Δ
adaptive/learner/balancing_learner.py71.74% <100.00%> (+1.05%)⬆️
adaptive/learner/average_learner1D.py73.66% <0.00%> (-1.00%)⬇️
adaptive/learner/learner1D.py86.91% <0.00%> (-0.75%)⬇️
adaptive/learner/learnerND.py59.10% <0.00%> (+0.37%)⬆️
adaptive/tests/test_cquad.py92.25% <0.00%> (+0.64%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt
basnijholt merged commit 6127d72 into mainOct 12, 2022
@basnijholt
basnijholt deleted the type-hint-balancing-learner branch October 12, 2022 06:30
@basnijholtbasnijholt mentioned this pull request Oct 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@basnijholt@codecov-commenter