Skip to content

Add type-hints to Learner2D - #375

Merged
basnijholt merged 1 commit into
mainfrom
type-hint-learner2D
Oct 12, 2022
Merged

Add type-hints to Learner2D#375
basnijholt merged 1 commit into
mainfrom
type-hint-learner2D

Conversation

@basnijholt

Copy link
Copy Markdown
Member

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholtbasnijholt changed the title Add type-hints to adaptive/learner/learner2D.pyAdd type-hints to Learner2DOct 12, 2022
@codecov-commenter

codecov-commenter commented Oct 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #375 (ab976a9) into main (8fd6de5) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #375 +/- ##
==========================================
- Coverage 77.69% 77.65% -0.05% 
==========================================
Files 37 37 Lines 5420 5423 +3 Branches 982 982 ==========================================
Hits 4211 4211 - Misses 1062 1064 +2 - Partials 147 148 +1 
Impacted FilesCoverage Δ
adaptive/tests/test_pickling.py88.67% <ø> (ø)
adaptive/learner/learner2D.py76.52% <100.00%> (+0.22%)⬆️
adaptive/tests/test_runner.py86.25% <100.00%> (ø)
adaptive/learner/learner1D.py86.73% <0.00%> (-0.99%)⬇️
adaptive/tests/test_cquad.py92.25% <0.00%> (+0.64%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt
basnijholtforce-pushed the type-hint-learner2D branch 3 times, most recently from 95a3da1 to ef0dbf7CompareOctober 12, 2022 22:02
@basnijholt
basnijholt enabled auto-merge (squash) October 12, 2022 22:07
@basnijholt
basnijholt enabled auto-merge (squash) October 12, 2022 22:52
@basnijholtbasnijholt mentioned this pull request Oct 12, 2022
@basnijholt
basnijholt merged commit e06b34c into mainOct 12, 2022
@basnijholt
basnijholt deleted the type-hint-learner2D branch October 12, 2022 23:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@basnijholt@codecov-commenter