Skip to content

gh-101277: Isolate itertools, add group and _grouper types to module state - #101302

Merged
erlend-aasland merged 14 commits into
python:mainfrom
erlend-aasland:isolate-itertools/batch-1
Feb 1, 2023
Merged

gh-101277: Isolate itertools, add group and _grouper types to module state#101302
erlend-aasland merged 14 commits into
python:mainfrom
erlend-aasland:isolate-itertools/batch-1

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jan 24, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Jan 24, 2023
Closed
@erlend-aasland

erlend-aasland commented Jan 24, 2023

Copy link
Copy Markdown
ContributorAuthor

This is part 1 of 4. I've split each PR so the diffs are ~200 lines of code, excluding clinic changes. This PR add helpers for fetching state, adds tests for type immutability, converts two of the types to heap types, and add them to the module state.

Follow-up PRs for the rest of the types are created as draft PRs; these will be rebased onto main after this PR has landed.

The last PR will purge the global-to-fix file, and add a NEWS entry.

erlend-aasland
erlend-aasland commented Jan 24, 2023
View reviewed changes
Comment threadModules/itertoolsmodule.c Outdated
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 25, 2023
@bedevere-bot

bedevere-bot commented Jan 25, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 6dc2032 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jan 25, 2023
@rhettinger
rhettinger removed their request for review January 29, 2023 03:46
erlend-aasland
erlend-aasland commented Jan 29, 2023
View reviewed changes
Comment threadModules/clinic/itertoolsmodule.c.h Outdated
rhettinger
rhettinger reviewed Jan 29, 2023
View reviewed changes
Comment threadModules/itertoolsmodule.c
@erlend-aaslanderlend-aasland mentioned this pull request Jan 29, 2023
Closed
@kumaraditya303kumaraditya303 self-assigned this Jan 31, 2023
kumaraditya303
kumaraditya303 reviewed Jan 31, 2023
View reviewed changes
Comment threadModules/itertoolsmodule.c Outdated
kumaraditya303
kumaraditya303 approved these changes Jan 31, 2023
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadModules/itertoolsmodule.c
@erlend-aasland

erlend-aasland commented Jan 31, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews! Highly appreciated. I'm considering landing this tomorrow.

erlend-aaslandand others added 2 commits January 31, 2023 19:03
@erlend-aasland@kumaraditya303
Update Modules/itertoolsmodule.c
4783565
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@erlend-aasland
Sync with main
cea6d40
erlend-aasland
erlend-aasland commented Jan 31, 2023
View reviewed changes
Comment threadModules/clinic/itertoolsmodule.c.h Outdated
@erlend-aasland

erlend-aasland commented Feb 1, 2023

Copy link
Copy Markdown
ContributorAuthor

I'm landing this shortly. I'll rebase #101303 onto main and mark it as ready for review.

Thanks again for the reviews.

@erlend-aasland
erlend-aasland merged commit 2b3e02a into python:mainFeb 1, 2023
@erlend-aasland
erlend-aasland deleted the isolate-itertools/batch-1 branch February 1, 2023 11:41
carljm added a commit to carljm/cpython that referenced this pull request Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051
* main:
pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
datetime.rst: fix combine() signature (python#101490)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettingerrhettingerrhettinger left review comments
@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

@kumaraditya303kumaraditya303

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@rhettinger@kumaraditya303