Skip to content

gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_tls() - #101335

Merged
kumaraditya303 merged 6 commits into
python:mainfrom
beavailable:fix-issue-101317
Feb 1, 2023
Merged

gh-101317: Add ssl_shutdown_timeout parameter for StreamWriter.start_tls()#101335
kumaraditya303 merged 6 commits into
python:mainfrom
beavailable:fix-issue-101317

Conversation

@beavailable

@beavailablebeavailable commented Jan 26, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Jan 26, 2023
Closed
@bedevere-bot

bedevere-bot commented Jan 26, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost

ghost commented Jan 26, 2023•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

kumaraditya303
kumaraditya303 requested changes Jan 31, 2023
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this param to docs with a version changed directive.

@bedevere-bot

bedevere-bot commented Jan 31, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@beavailable

beavailable commented Feb 1, 2023

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

kumaraditya303
kumaraditya303 reviewed Feb 1, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-01-26-01-25-56.gh-issue-101317.vWaS1x.rst Outdated
kumaraditya303
kumaraditya303 reviewed Feb 1, 2023
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2023-01-26-01-25-56.gh-issue-101317.vWaS1x.rst Outdated
@kumaraditya303kumaraditya303 linked an issue Feb 1, 2023 that may be closed by this pull request
Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio #101317
Closed
@kumaraditya303kumaraditya303 self-assigned this Feb 1, 2023
@kumaraditya303
kumaraditya303 merged commit cc407b9 into python:mainFeb 1, 2023
@kumaraditya303

kumaraditya303 commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

Thanks.

@beavailable
beavailable deleted the fix-issue-101317 branch February 1, 2023 11:05
carljm added a commit to carljm/cpython that referenced this pull request Feb 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
8b76051
* main:
pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481)
pythongh-98831: Modernize the LOAD_ATTR family (python#101488)
pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499)
pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455)
pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302)
pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335)
datetime.rst: fix combine() signature (python#101490)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

@kumaraditya303kumaraditya303

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add the ssl_shutdown_timeout parameter for StreamWriter.start_tls() in asyncio

3 participants

@beavailable@bedevere-bot@kumaraditya303