Skip to content

gh-72249: Include the module name in the repr of partial object - #101910

Merged
serhiy-storchaka merged 18 commits into
python:mainfrom
furkanonder:issue-72249
Feb 25, 2024
Merged

gh-72249: Include the module name in the repr of partial object#101910
serhiy-storchaka merged 18 commits into
python:mainfrom
furkanonder:issue-72249

Conversation

@furkanonder

@furkanonderfurkanonder commented Feb 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Co-authored-by: Anilyka Barry

@furkanonderfurkanonder changed the title Include the module name in the repr of functoolGH-72249: Include the module name in the repr of functoolFeb 14, 2023
@bedevere-botbedevere-bot mentioned this pull request Feb 14, 2023
Closed
@furkanonderfurkanonder changed the title GH-72249: Include the module name in the repr of functoolGH-72249: Include the module name in the repr of partial objectFeb 14, 2023
@rhettinger
rhettinger removed their request for review February 15, 2023 03:33
@arhadthedevarhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 15, 2023
@furkanonderfurkanonder changed the title GH-72249: Include the module name in the repr of partial objectgh-72249: Include the module name in the repr of partial objectAug 6, 2023
serhiy-storchaka
serhiy-storchaka reviewed Feb 17, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Feb 17, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Feb 20, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
Comment threadModules/_functoolsmodule.c
Comment threadModules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Feb 24, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
sobolevn
sobolevn reviewed Feb 25, 2024
View reviewed changes
Comment threadLib/functools.py Outdated
serhiy-storchaka
serhiy-storchaka reviewed Feb 25, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
Comment threadModules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Feb 25, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Feb 25, 2024
View reviewed changes
Comment threadModules/_functoolsmodule.c Outdated
serhiy-storchaka
serhiy-storchaka approved these changes Feb 25, 2024
View reviewed changes

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka
serhiy-storchaka merged commit 8f5be78 into python:mainFeb 25, 2024
@Vgr255

Vgr255 commented Feb 25, 2024

Copy link
Copy Markdown
Contributor

Thank you @furkanonder for this! I haven't been active in CPython in years, appreciate the continued work.

@furkanonder

furkanonder commented Feb 25, 2024

Copy link
Copy Markdown
ContributorAuthor

@serhiy-storchaka Thank you so much for your feedback, patience (sometimes explaining my mistakes over and over again), and time. I'd want to thank you again for providing me with the opportunity to better understand the CPython code-base.

@furkanonder

furkanonder commented Feb 25, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you @furkanonder for this! I haven't been active in CPython in years, appreciate the continued work.

You are welcome!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@furkanonder@Vgr255@woodruffw
pythongh-72249: Include the module name in the repr of partial object (…
04d8551
…pythonGH-101910)
Co-authored-by: Anilyka Barry <vgr255@live.ca>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@furkanonder@Vgr255@adorilson
pythongh-72249: Include the module name in the repr of partial object (…
c90c72a
…pythonGH-101910)
Co-authored-by: Anilyka Barry <vgr255@live.ca>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@furkanonder@Vgr255@diegorusso
pythongh-72249: Include the module name in the repr of partial object (…
f193ce8
…pythonGH-101910)
Co-authored-by: Anilyka Barry <vgr255@live.ca>
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@furkanonder@Vgr255@LukasWoodtli
pythongh-72249: Include the module name in the repr of partial object (…
3d93703
…pythonGH-101910)
Co-authored-by: Anilyka Barry <vgr255@live.ca>
zware added a commit to zware/cpython that referenced this pull request Sep 3, 2025
@zware
pythongh-72249: Correct wording ofpythonGH-101910blurb
504eae4
zware added a commit that referenced this pull request Sep 3, 2025
@zware
gh-72249: Correct wording ofGH-101910blurb (GH-138468)
007bc5f
This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2025
@zware@miss-islington
pythongh-72249: Correct wording ofpythonGH-101910blurb (pythonGH-13…
9195d57
…8468)
This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
(cherry picked from commit 007bc5f)
Co-authored-by: Zachary Ware <zach@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2025
@zware@miss-islington
pythongh-72249: Correct wording ofpythonGH-101910blurb (pythonGH-13…
07a32be
…8468)
This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
(cherry picked from commit 007bc5f)
Co-authored-by: Zachary Ware <zach@python.org>
zware pushed a commit that referenced this pull request Sep 3, 2025
@miss-islington
[3.13]gh-72249: Correct wording ofGH-101910blurb (GH-138471)
e8280e3
This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
(cherry picked from commit 007bc5f)
hugovk pushed a commit that referenced this pull request Sep 3, 2025
@miss-islington@zware
[3.14]gh-72249: Correct wording ofGH-101910blurb (GH-138468) (#138470
45a79b4
)
Co-authored-by: Zachary Ware <zach@python.org>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington@zware@kumaraditya303
[3.14]pythongh-72249: Correct wording ofpythonGH-101910blurb (pyth…
a698b08
…onGH-138468) (python#138470)
Co-authored-by: Zachary Ware <zach@python.org>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@zware@lkollar
pythongh-72249: Correct wording ofpythonGH-101910blurb (pythonGH-13…
24068c8
…8468)
This incidentally corrects a reST issue reported by Daniel Nylander from the Swedish translation.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments
@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@furkanonder@Vgr255@serhiy-storchaka@sobolevn@arhadthedev@bedevere-bot