Skip to content

Remove redundant _ensure_future in favor of ensure_future in asyncio - #102398

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:task-refactor
Mar 7, 2023
Merged

Remove redundant _ensure_future in favor of ensure_future in asyncio#102398
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:task-refactor

Conversation

@kumaraditya303

Copy link
Copy Markdown
Contributor

It serves no purpose and it annoys me to think when working as what is the difference between _ensure_future and ensure_future.

@auvipyauvipy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Presumably there was a difference in the past.

@kumaraditya303
kumaraditya303 merged commit d8485d6 into python:mainMar 7, 2023
@kumaraditya303
kumaraditya303 deleted the task-refactor branch March 7, 2023 13:14
carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
* main:
pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
pythongh-90110: Fix the c-analyzer Tool (python#102483)
pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
Remove unused import of `warnings` from `unittest.loader` (python#102479)
Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
* main:
pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
pythongh-90110: Fix the c-analyzer Tool (python#102483)
pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
Remove unused import of `warnings` from `unittest.loader` (python#102479)
Add gettext support to tools/extensions/c_annotations.py (python#101989)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303@gvanrossum@auvipy@bedevere-bot