Skip to content

Remove the unused import 'warnings' from unittest's loader module - #102479

Merged
AlexWaygood merged 1 commit into
python:mainfrom
JosephSBoyle:remove-unused-warnings-import
Mar 6, 2023
Merged

Remove the unused import 'warnings' from unittest's loader module#102479
AlexWaygood merged 1 commit into
python:mainfrom
JosephSBoyle:remove-unused-warnings-import

Conversation

@JosephSBoyle

Copy link
Copy Markdown
Contributor

Not the most glamorous PR, but the import isn't being used and is imported every time $python -m unittest is run.

Warnings is lazily imported in this file prior to use.

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood

Copy link
Copy Markdown
Member

(I checked, the import is actually used on the 3.11 branch, so this can't be backported.)

carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
* main:
pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
pythongh-90110: Fix the c-analyzer Tool (python#102483)
pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
Remove unused import of `warnings` from `unittest.loader` (python#102479)
Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
* main:
pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
pythongh-90110: Fix the c-analyzer Tool (python#102483)
pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
Remove unused import of `warnings` from `unittest.loader` (python#102479)
Add gettext support to tools/extensions/c_annotations.py (python#101989)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@JosephSBoyle@AlexWaygood@bedevere-bot