Uh oh!
There was an error while loading. Please reload this page.
gh-83004: Harden winsound init - #103385
Merged
Merged
Conversation
hauntsaninja
left a comment
Contributor
There was a problem hiding this comment.
Nice cleanup! Should we decref module in the error case?
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
kumaraditya303
approved these changes
Apr 9, 2023
ContributorAuthor
Thanks for the review, Kumar & Shantanu! |
warsaw pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
aisk pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.