gh-87106: Fix `inspect.signature.bind` handling of positional-only arguments with `**kwargs` by jacobtylerwalls · Pull Request #103404 · python/cpython

jacobtylerwalls · 2023-04-10T04:45:28Z

If a function signature has a variadic keyword argument (like **kwargs), then providing a keyword with the same name as a positional-only argument will still succeed, and become available on kwargs.

Before
inspect.signature(f).bind(pos_only='val') might either:

raise TypeError unnecessarily if the positional-only arg had a default
raise TypeError with a different flavor of error message than runtime (runtime mentions the missing positional arg, but bind() mentioned the name collision, which wasn't the problem)

Now
These are fixed.

Prior related work
#16800

…nly arguments with `**kwargs`

sobolevn

Thanks!

jacobtylerwalls · 2024-05-04T23:37:07Z

👋 @sobolevn would you be interested to take another look?

sobolevn

I agree with the fix in general. However, there are still some things to polish and improve :)

Thanks a lot for your work!

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

jacobtylerwalls · 2024-05-05T15:28:26Z

Thanks for your suggestions, @sobolevn. Should I move some of the new cases to test_signature_bind_posonly_kwargs()?

sobolevn

@serhiy-storchaka do you have any additional feedback?

serhiy-storchaka

LGTM.

miss-islington-app · 2024-05-13T07:56:41Z

Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2024-05-13T07:56:41Z

Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…nly arguments with **kwargs (pythonGH-103404) (cherry picked from commit 9c15202) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>

bedevere-app · 2024-05-13T07:56:58Z

GH-118984 is a backport of this pull request to the 3.12 branch.

bedevere-app · 2024-05-13T07:57:05Z

GH-118985 is a backport of this pull request to the 3.13 branch.

…only arguments with **kwargs (GH-103404) (GH-118984) (cherry picked from commit 9c15202) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>

…only arguments with **kwargs (GH-103404) (#118985) (cherry picked from commit 9c15202) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>

…nly arguments with **kwargs (pythonGH-103404)

pythongh-87106: Fixinspect.signature.bindhandling of positional-o…
f2baf1a
…nly arguments with `**kwargs`

bedevere-bot mentioned this pull request Apr 10, 2023
Incorrect behavior of inspect.signature(f).bind #87106
Closed

bedevere-bot added the awaiting review label Apr 10, 2023

fixup: double backticks
487e217

sobolevn reviewed Apr 10, 2023
View reviewed changes

Comment threadLib/test/test_inspect.py Outdated
Comment threadLib/test/test_inspect.py

sobolevn requested a review from larryhastings April 10, 2023 06:44

jacobtylerwalls added 2 commits April 14, 2023 22:54

Merge branch 'main' into issue-87106
c1e6af2

Avoid having helper function start with "test"
b7cbfe4

sobolevn mentioned this pull request Apr 15, 2023
Incorrect inspect.Signature can be created: pos-only with a default followed by pos-or-kw without one #103556
Closed

jacobtylerwalls requested a review from sobolevn July 23, 2023 23:59

jacobtylerwalls added 2 commits November 19, 2023 08:27

Merge branch 'main' into issue-87106
600e778

Merge branch 'main' into issue-87106
eebae66

Merge branch 'main' into issue-87106
1c7aa83

sobolevn reviewed May 5, 2024
View reviewed changes

Comment threadLib/test/test_inspect/test_inspect.py
Comment threadLib/test/test_inspect/test_inspect.py Outdated
Comment threadLib/inspect.py Outdated
Comment threadLib/inspect.py Outdated
Comment threadLib/inspect.py Outdated

jacobtylerwallsand others added 6 commits May 5, 2024 09:37

Opt for black style
cc2d7ba
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Simplify test case
366bb96

Add test cases
2f792eb

Use elif
5951ad9

Refactor to avoid pop-and-maybe-put-back pattern
2ecde83

Remove unnecessary cosmetic changes
db2d925

jacobtylerwalls commented May 5, 2024
View reviewed changes

Comment threadLib/inspect.py

Test multiple pos-only args passed by keyword
6916290

jacobtylerwalls requested a review from sobolevn May 5, 2024 15:15

sobolevn approved these changes May 9, 2024
View reviewed changes

bedevere-appBot added awaiting merge and removed awaiting review labels May 9, 2024

serhiy-storchaka self-requested a review May 9, 2024 13:17

serhiy-storchaka reviewed May 9, 2024
View reviewed changes

Comment threadLib/test/test_inspect/test_inspect.py Outdated
Comment threadLib/test/test_inspect/test_inspect.py Outdated
Comment threadLib/inspect.py Outdated
Comment threadLib/inspect.py

jacobtylerwalls added 2 commits May 10, 2024 08:27

Remove superfluous continue
1ec398b

[tests] Use distinct value for c_po kwarg
f1565de

jacobtylerwalls requested a review from serhiy-storchaka May 10, 2024 12:38

serhiy-storchaka reviewed May 10, 2024
View reviewed changes

Comment threadLib/test/test_inspect/test_inspect.py Outdated
Comment threadLib/inspect.py

fixup! [tests] Use distinct value for c_po kwarg
52facb0

serhiy-storchaka approved these changes May 12, 2024
View reviewed changes

serhiy-storchaka merged commit 9c15202 into python:mainMay 13, 2024

bedevere-appBot removed the awaiting merge label May 13, 2024

serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 13, 2024

bedevere-appBot removed the needs backport to 3.12 only security fixes label May 13, 2024

bedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 13, 2024

JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-87106: Fix inspect.signature.bind() handling of positional-o…
8786b75
…nly arguments with **kwargs (pythonGH-103404)

hoodmane mentioned this pull request Nov 6, 2024
Upgrade to Python 3.12.7 pyodide/pyodide#5149
Merged
6 tasks

dfremont mentioned this pull request Feb 15, 2025
Signature.bind allows certain positional-only parameters as keywords #130164
Closed

jacobtylerwalls deleted the issue-87106 branch February 15, 2025 23:42

jacobtylerwalls mentioned this pull request Feb 17, 2025
gh-130164: Fix inspect.Signature.bind() handling of positional-only args without defaults #130192
Merged

Uh oh!

Uh oh!

Conversation

jacobtylerwalls commented Apr 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jacobtylerwalls commented May 4, 2024

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacobtylerwalls commented May 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-appBot commented May 13, 2024

Uh oh!

miss-islington-appBot commented May 13, 2024

Uh oh!

bedevere-appBot commented May 13, 2024

Uh oh!

bedevere-appBot commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jacobtylerwalls commented Apr 10, 2023•
edited
Loading

jacobtylerwalls commented May 5, 2024•
edited
Loading