bpo-38478: Correctly handle keyword argument with same name as positional-only parameter by pablogsal · Pull Request #16800 · python/cpython

pablogsal · 2019-10-15T10:40:55Z

https://bugs.python.org/issue38478

…onal-only parameter

pablogsal · 2019-10-15T10:41:16Z

CC: @tirkarthi Would you like to review this pr? :)

tirkarthi

LGTM. I too had the same solution in mind since it's simple . Thanks Pablo :)

pablogsal · 2019-10-15T11:39:46Z

Thanks @tirkarthi :)

miss-islington · 2019-10-15T11:40:05Z

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot · 2019-10-15T11:40:27Z

GH-16801 is a backport of this pull request to the 3.8 branch.

…onal-only parameter (pythonGH-16800) (cherry picked from commit f3ef06a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

…onal-only parameter (GH-16800) (cherry picked from commit f3ef06a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

pablogsal · 2019-10-15T12:45:51Z

The buildbot failure is unrelated: test_start_tls_server_1

bedevere-bot · 2019-10-15T13:25:16Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.8 has failed when building commit f705f8e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/214/builds/436) and take a look at the build logs.
Check if the failure is related to this commit (f705f8e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/214/builds/436

Failed tests:

test_asyncio

Failed subtests:

test_start_tls_server_1 - test.test_asyncio.test_sslproto.SelectorStartTLSTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

414 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 3 sec
test_multiprocessing_spawn: 2 min 39 sec
test_tokenize: 2 min 3 sec
test_asyncio: 1 min 32 sec
test_multiprocessing_forkserver: 1 min 29 sec
test_tools: 1 min 23 sec
test_lib2to3: 1 min 13 sec
test_multiprocessing_fork: 1 min 13 sec
test_io: 42.1 sec
test_subprocess: 39.0 sec

1 test failed:
test_asyncio

8 tests skipped:
test_devpoll test_kqueue test_msilib test_startfile
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_asyncio

Total duration: 19 min 28 sec

Click to see traceback logs

Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_sslproto.py", line 585, in test_start_tls_server_1self.loop.run_until_complete(run_main())
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 606, in run_until_completeraiseRuntimeError('Event loop stopped before Future completed.')
RuntimeError: Event loop stopped before Future completed.
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 190, in runself._prog(TestSocketWrapper(self._sock))
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_sslproto.py", line 575, in <lambda>withself.tcp_client(lambdasock: client(sock, addr),
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_sslproto.py", line 520, in client
answer = sock.recv_all(len(ANSWER))
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 130, in recv_all
data =self.recv(n -len(buf))
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/ssl.py", line 1226, in recvreturnself.read(buflen)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/ssl.py", line 1101, in readreturnself._sslobj.read(len)
ssl.SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:2560)
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 1729, in call_exception_handlerself._exception_handler(self, context)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 22, in loop_exception_handlerself.loop.default_exception_handler(context)
AttributeError: 'NoneType' object has no attribute 'default_exception_handler'
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_streams.py:40: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 40133)>
gc.collect()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/selector_events.py:684: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=8>
_warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/sslproto.py:321: ResourceWarning: unclosed transport <asyncio.sslproto._SSLProtocolTransport object at 0xb5f673b8>
_warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
Unhandled error in exception handler
context: {'message': 'Fatal error on SSL transport', 'exception': RuntimeError('Event loop is closed'), 'transport': <_SelectorSocketTransport closing fd=8>, 'protocol': <asyncio.sslproto.SSLProtocol object at 0xb607d0e8>}
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/selector_events.py", line 898, in write
n =self._sock.send(data)
OSError: [Errno 9] Bad file descriptor
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 932, in _bootstrap_innerself.run()
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 192, in runself._test._abort_socket_test(ex)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 114, in _abort_socket_testself.fail(ex)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 753, in failraiseself.failureException(msg)
AssertionError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:2560)
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/threading.py:934: ResourceWarning: unclosed <ssl.SSLSocket fd=7, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 45534), raddr=('127.0.0.1', 41207)>
self._invoke_excepthook(self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
ERROR
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 932, in _bootstrap_innerself.run()
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 192, in runself._test._abort_socket_test(ex)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 114, in _abort_socket_testself.fail(ex)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 753, in failraiseself.failureException(msg)
AssertionError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:2560)
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/threading.py:934: ResourceWarning: unclosed <ssl.SSLSocket fd=7, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 43192), raddr=('127.0.0.1', 40133)>
self._invoke_excepthook(self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
ERROR
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 1729, in call_exception_handlerself._exception_handler(self, context)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 22, in loop_exception_handlerself.loop.default_exception_handler(context)
AttributeError: 'NoneType' object has no attribute 'default_exception_handler'
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_streams.py:40: ResourceWarning: unclosed <socket.socket fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 41207)>
gc.collect()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
k
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 1729, in call_exception_handlerself._exception_handler(self, context)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 22, in loop_exception_handlerself.loop.default_exception_handler(context)
AttributeError: 'NoneType' object has no attribute 'default_exception_handler'
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_streams.py:40: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 41207)>
gc.collect()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/selector_events.py:684: ResourceWarning: unclosed transport <_SelectorSocketTransport fd=8>
_warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/sslproto.py:321: ResourceWarning: unclosed transport <asyncio.sslproto._SSLProtocolTransport object at 0xb418ff58>
_warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback
Unhandled error in exception handler
context: {'message': 'Fatal error on SSL transport', 'exception': RuntimeError('Event loop is closed'), 'transport': <_SelectorSocketTransport closing fd=8>, 'protocol': <asyncio.sslproto.SSLProtocol object at 0xb3eec238>}
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/selector_events.py", line 898, in write
n =self._sock.send(data)
OSError: [Errno 9] Bad file descriptor
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 1729, in call_exception_handlerself._exception_handler(self, context)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/functional.py", line 22, in loop_exception_handlerself.loop.default_exception_handler(context)
AttributeError: 'NoneType' object has no attribute 'default_exception_handler'
/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_asyncio/test_streams.py:40: ResourceWarning: unclosed <socket.socket fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 40133)>
gc.collect()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
k
Traceback (most recent call last):
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/sslproto.py", line 685, in _process_write_backlogself._transport.write(chunk)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/selector_events.py", line 904, in writeself._fatal_error(exc, 'Fatal write error on socket transport')
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/selector_events.py", line 699, in _fatal_errorself._force_close(exc)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/selector_events.py", line 711, in _force_closeself._loop.call_soon(self._call_connection_lost, exc)
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 711, in call_soonself._check_closed()
File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/asyncio/base_events.py", line 504, in _check_closedraiseRuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

…onal-only parameter (pythonGH-16800)

bpo-38478: Correctly handle keyword argument with same name as positi…
adf8e20
…onal-only parameter

the-knights-who-say-ni added the CLA signed label Oct 15, 2019

pablogsal self-assigned this Oct 15, 2019

bedevere-bot added the awaiting core review label Oct 15, 2019

pablogsal added the needs backport to 3.8 label Oct 15, 2019

tirkarthi approved these changes Oct 15, 2019
View reviewed changes

pablogsal merged commit f3ef06a into python:masterOct 15, 2019

pablogsal deleted the bpo-38478 branch October 15, 2019 11:40

bedevere-bot removed the awaiting core review label Oct 15, 2019

bedevere-bot removed the needs backport to 3.8 label Oct 15, 2019

miss-islington added a commit that referenced this pull request Oct 15, 2019
bpo-38478: Correctly handle keyword argument with same name as positi…
f705f8e
…onal-only parameter (GH-16800) (cherry picked from commit f3ef06a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

python deleted a comment from bedevere-bot Oct 15, 2019

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
bpo-38478: Correctly handle keyword argument with same name as positi…
e70edd7
…onal-only parameter (pythonGH-16800)

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-38478: Correctly handle keyword argument with same name as positi…
1423392
…onal-only parameter (pythonGH-16800)

jacobtylerwalls mentioned this pull request Apr 10, 2023
gh-87106: Fix inspect.signature.bind handling of positional-only arguments with **kwargs#103404
Merged

Navigation Menu

Uh oh!

Uh oh!

bpo-38478: Correctly handle keyword argument with same name as positional-only parameter - #16800

bpo-38478: Correctly handle keyword argument with same name as positional-only parameter#16800
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-38478

pablogsal commented Oct 15, 2019•
edited by bedevere-bot
Loading

Uh oh!

pablogsal commented Oct 15, 2019•
edited
Loading

Uh oh!

tirkarthi left a comment

Uh oh!

pablogsal commented Oct 15, 2019

Uh oh!

miss-islington commented Oct 15, 2019

Uh oh!

bedevere-bot commented Oct 15, 2019

Uh oh!

pablogsal commented Oct 15, 2019

Uh oh!

bedevere-bot commented Oct 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

pablogsal commented Oct 15, 2019• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pablogsal commented Oct 15, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tirkarthi left a comment

Choose a reason for hiding this comment

Uh oh!

pablogsal commented Oct 15, 2019

Uh oh!

miss-islington commented Oct 15, 2019

Uh oh!

bedevere-bot commented Oct 15, 2019

Uh oh!

pablogsal commented Oct 15, 2019

Uh oh!

bedevere-bot commented Oct 15, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pablogsal commented Oct 15, 2019•
edited by bedevere-bot
Loading

pablogsal commented Oct 15, 2019•
edited
Loading