Skip to content

gh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath - #103842

Merged
ned-deily merged 4 commits into
python:mainfrom
chrstphrchvz:patch-103839
May 19, 2023
Merged

gh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath#103842
ned-deily merged 4 commits into
python:mainfrom
chrstphrchvz:patch-103839

Conversation

@chrstphrchvz

@chrstphrchvzchrstphrchvz commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Assume tommath.h is available somewhere
if Tcl was built with external libtommath.
@arhadthedevarhadthedev added awaiting review topic-tkinter build The build process and cross-build labels Apr 26, 2023
@chrstphrchvz

Copy link
Copy Markdown
ContributorAuthor

Although checking for TCL_WITH_EXTERNAL_TOMMATH before defining TCL_NO_TOMMATH_H seems correct to me, I now notice some inadequacies in how Tkinter is gathering Tcl build flags and/or how Tcl is reporting them. By default, Tkinter tries to use pkg-config to obtain Cflags from …/lib/pkgconfig/tcl.pc. But Tcl only records the -DTCL_WITH_EXTERNAL_TOMMATH flag in the TCL_DEFS line of tclConfig.sh (which is where Tcl/Tk software conventionally would check); most of the information in tclConfig.sh is not present in tcl.pc. I will likely ask Tcl if this can be improved.

@ned-deilyned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a step toward future full support of Tk 8.7, this seems harmless enough. I don't think it should be backported until and unless we decide to backport full 8.7 support with subsequent PRs.

@ned-deily
ned-deily merged commit 625887e into python:mainMay 19, 2023
@chrstphrchvz
chrstphrchvz deleted the patch-103839 branch May 19, 2023 20:04
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this pull request May 20, 2023
* main: (30 commits)
pythongh-103987: fix several crashes in mmap module (python#103990)
docs: fix wrong indentation causing rendering error in dis page (python#104661)
pythongh-94906: Support multiple steps in math.nextafter (python#103881)
pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
pythongh-85984: New additions and improvements to the tty library. (python#101832)
pythongh-104659: Consolidate python examples in enum documentation (python#104665)
pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
pythongh-104645: fix error handling in marshal tests (python#104646)
pythongh-104600: Make type.__type_params__ writable (python#104634)
pythongh-104602: Add additional test for listcomp with lambda (python#104639)
pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
pythongh-103921: Rename "type" header in argparse docs (python#104654)
Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
pythongh-96522: Fix deadlock in pty.spawn (python#96639)
pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline. (pythonGH-104579)
pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
pythongh-104602: ensure all cellvars are known up front (python#104603)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildThe build process and cross-buildtopic-tkinter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chrstphrchvz@ned-deily@arhadthedev@bedevere-bot