Skip to content

gh-104472: Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled - #104667

Merged
gpshead merged 2 commits into
python:mainfrom
chgnrdv:skip-subprocess-process-empty-env-test-with-asan
May 19, 2023
Merged

gh-104472: Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled#104667
gpshead merged 2 commits into
python:mainfrom
chgnrdv:skip-subprocess-process-empty-env-test-with-asan

Conversation

@chgnrdv

@chgnrdvchgnrdv commented May 19, 2023

Copy link
Copy Markdown
Contributor

@gpshead
gpshead enabled auto-merge (squash) May 19, 2023 19:00
@gpsheadgpshead added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels May 19, 2023
@gpshead
gpshead merged commit c3f43bf into python:mainMay 19, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @chgnrdv for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @chgnrdv and @gpshead, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker c3f43bfb4bec39ff8f2c36d861a3c3a243bcb3af 3.11

@bedevere-bot

Copy link
Copy Markdown

GH-104669 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2023
…` if ASAN is enabled (pythonGH-104667)
Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)
Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
@gpsheadgpshead added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 19, 2023
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @chgnrdv for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-104673 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2023
…` if ASAN is enabled (pythonGH-104667)
Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)
Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request May 19, 2023
…v` if ASAN is enabled (GH-104667) (#104669)
gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (GH-104667)
Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)
Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
gpshead pushed a commit that referenced this pull request May 19, 2023
…v` if ASAN is enabled (GH-104667) (#104673)
gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (GH-104667)
Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)
Co-authored-by: chgnrdv <52372310+chgnrdv@users.noreply.github.com>
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this pull request May 20, 2023
* main: (30 commits)
pythongh-103987: fix several crashes in mmap module (python#103990)
docs: fix wrong indentation causing rendering error in dis page (python#104661)
pythongh-94906: Support multiple steps in math.nextafter (python#103881)
pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
pythongh-85984: New additions and improvements to the tty library. (python#101832)
pythongh-104659: Consolidate python examples in enum documentation (python#104665)
pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
pythongh-104645: fix error handling in marshal tests (python#104646)
pythongh-104600: Make type.__type_params__ writable (python#104634)
pythongh-104602: Add additional test for listcomp with lambda (python#104639)
pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
pythongh-103921: Rename "type" header in argparse docs (python#104654)
Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
pythongh-96522: Fix deadlock in pty.spawn (python#96639)
pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline. (pythonGH-104579)
pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
pythongh-104602: ensure all cellvars are known up front (python#104603)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASAN failure was detected while running test_threading

5 participants

@chgnrdv@miss-islington@bedevere-bot@gpshead@sunmy2019