gh-104456: Fix ref leak in _ctypes.COMError by Eclips4 · Pull Request #104457 · python/cpython

Eclips4 · 2023-05-13T19:55:17Z

Issue: test_ctypes are leaked #104456

Eclips4 · 2023-05-13T19:56:45Z

Seems that related to #104020
@erlend-aasland

bedevere-bot · 2023-05-13T19:59:35Z

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 8dbad09 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

Eclips4 · 2023-05-13T20:08:28Z

Thanks Alex for the buildbots start. But, no one from buildbots use a windows system.
In issue I've mentioned that this refleak only reproducible on Windows, because COMError exist only on Windows.
So... buildbots can't catch this refleak :(
However, maybe add a one buildbot with windows system to buildbots ecosystem? I think it's will be useful.
(of course, this should be a another issue)

AlexWaygood · 2023-05-13T20:11:44Z

!buildbot Windows.*Refleak

bedevere-bot · 2023-05-13T20:11:46Z

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 8dbad09 🤖

The command will test the builders whose names match following regular expression: Windows.*Refleak

The builders matched are:

AlexWaygood · 2023-05-13T20:12:34Z

!buildbot .*Windows.Refleak.

bedevere-bot · 2023-05-13T20:12:36Z

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 8dbad09 🤖

The command will test the builders whose names match following regular expression: .*Windows.*Refleak.*

The builders matched are:

erlend-aasland

Please add a Py_tp_clear slot and do the work there. You can call that function from dealloc. Also, the traverse function must be updated similarly.

bedevere-bot · 2023-05-13T20:48:18Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

erlend-aasland · 2023-05-13T20:48:54Z

Also, in dealloc we first untrack from GC, then we clear.

Eclips4 · 2023-05-13T21:11:39Z

I have made the requested changes; please review again

bedevere-bot · 2023-05-13T21:11:42Z

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

erlend-aasland · 2023-05-13T22:15:24Z

I left some more remarks. I'll follow this up tomorrow.

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

sunmy2019 · 2023-05-14T16:57:12Z

Could you let me know if you've confirmed the error is fixed on Windows? @Eclips4

Eclips4 · 2023-05-14T18:17:50Z

Could you let me know if you've confirmed the error is fixed on Windows? @Eclips4

Yeah, refleak are gone:

 ./python-mtest-R3:3test_ctypesRunningDebug|x64interpreter...
0:00:00Runtestssequentially0:00:00 [1/1] test_ctypesbeginning6repetitions123456a=5, b=10, c=15a=5, b=10, c=15
.a=5, b=10, c=15a=5, b=10, c=15
.a=5, b=10, c=15a=5, b=10, c=15
.a=5, b=10, c=15a=5, b=10, c=15
.a=5, b=10, c=15a=5, b=10, c=15
.a=5, b=10, c=15a=5, b=10, c=15
.
test_ctypespassedin31.2sec==Testsresult: SUCCESS==1testOK.
Totalduration: 31.3secTestsresult: SUCCESS

Also, thanks for your help!

erlend-aasland · 2023-05-14T20:48:45Z

Thanks!

* main: (29 commits) pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418) pythongh-101819: Isolate `_io` (python#101948) Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501) pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495) pythongh-104050: Run mypy on `clinic.py` in CI (python#104421) pythongh-104490: Consistently define phony make targets (python#104491) pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473) pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488) pythongh-101282: move BOLT config after PGO (pythongh-104493) pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470) pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457) pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474) pythongh-104337: Clarify random.gammavariate doc entry (python#104410) Minor improvements to typing docs (python#104465) pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460) pythonGH-71383: IDLE - Document testing subsets of modules (python#104463) pythongh-104454: Fix refleak in AttributeError_reduce (python#104455) pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446) pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424) Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430) ...

* main: (204 commits) pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418) pythongh-101819: Isolate `_io` (python#101948) Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501) pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495) pythongh-104050: Run mypy on `clinic.py` in CI (python#104421) pythongh-104490: Consistently define phony make targets (python#104491) pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473) pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488) pythongh-101282: move BOLT config after PGO (pythongh-104493) pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470) pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457) pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474) pythongh-104337: Clarify random.gammavariate doc entry (python#104410) Minor improvements to typing docs (python#104465) pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460) pythonGH-71383: IDLE - Document testing subsets of modules (python#104463) pythongh-104454: Fix refleak in AttributeError_reduce (python#104455) pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446) pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424) Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430) ...

pythongh-104456: Fix ref leak in test_ctypes
8dbad09

bedevere-bot added the awaiting review label May 13, 2023

bedevere-bot mentioned this pull request May 13, 2023
test_ctypes are leaked #104456
Closed

AlexWaygood added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 13, 2023

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 13, 2023

erlend-aasland requested changes May 13, 2023
View reviewed changes

bedevere-bot removed the awaiting review label May 13, 2023

bedevere-bot added the awaiting changes label May 13, 2023

Add suggestion
28ac7ed

bedevere-bot added awaiting change review and removed awaiting changes labels May 13, 2023

bedevere-bot requested a review from erlend-aasland May 13, 2023 21:11

gpshead assigned erlend-aasland May 13, 2023

erlend-aasland reviewed May 13, 2023
View reviewed changes

Comment threadModules/_ctypes/_ctypes.c Outdated

erlend-aasland reviewed May 13, 2023
View reviewed changes

Comment threadModules/_ctypes/_ctypes.c Outdated

erlend-aasland reviewed May 13, 2023
View reviewed changes

Comment threadModules/_ctypes/_ctypes.c Outdated

Eclips4and others added 2 commits May 14, 2023 01:53

Update Modules/_ctypes/_ctypes.c
91e8893
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

add suggestions from sunmy2019
e317450

Eclips4 commented May 14, 2023
View reviewed changes

Comment threadModules/_ctypes/_ctypes.c

sunmy2019 reviewed May 14, 2023
View reviewed changes

Comment threadModules/_ctypes/_ctypes.c

sunmy2019 approved these changes May 14, 2023
View reviewed changes

erlend-aasland reviewed May 14, 2023
View reviewed changes

Comment threadModules/_ctypes/_ctypes.c Outdated

Update Modules/_ctypes/_ctypes.c
019234e

erlend-aasland added the skip news label May 14, 2023

erlend-aasland changed the title ~~gh-104456: Fix ref leak in test_ctypes~~gh-104456: Fix ref leak in _ctypes.COMErrorMay 14, 2023

erlend-aasland approved these changes May 14, 2023
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 14, 2023

erlend-aasland enabled auto-merge (squash) May 14, 2023 20:48

erlend-aasland merged commit 2cd1c87 into python:mainMay 14, 2023

bedevere-bot removed the awaiting merge label May 14, 2023

Eclips4 deleted the issue-104456 branch May 14, 2023 21:16

sunmy2019 mentioned this pull request May 15, 2023
Ref leaks introduced by _io isolation (gh-101948) #104510
Closed

Uh oh!

Uh oh!

Conversation

Eclips4 commented May 13, 2023• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eclips4 commented May 13, 2023

Uh oh!

bedevere-bot commented May 13, 2023

Uh oh!

Eclips4 commented May 13, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood commented May 13, 2023

Uh oh!

bedevere-bot commented May 13, 2023

Uh oh!

AlexWaygood commented May 13, 2023

Uh oh!

bedevere-bot commented May 13, 2023

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented May 13, 2023

Uh oh!

erlend-aasland commented May 13, 2023

Uh oh!

Eclips4 commented May 13, 2023

Uh oh!

bedevere-bot commented May 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented May 13, 2023

Uh oh!

Uh oh!

Uh oh!

sunmy2019 commented May 14, 2023

Uh oh!

Eclips4 commented May 14, 2023

Uh oh!

Uh oh!

erlend-aasland commented May 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Eclips4 commented May 13, 2023•
edited by bedevere-bot
Loading

Eclips4 commented May 13, 2023•
edited
Loading