Skip to content

gh-87092: avoid gcc warning on uninitialized struct field in assemble.c - #104460

Merged
iritkatriel merged 2 commits into
python:mainfrom
corona10:no-issue-remove-compiler-warn
May 14, 2023
Merged

gh-87092: avoid gcc warning on uninitialized struct field in assemble.c#104460
iritkatriel merged 2 commits into
python:mainfrom
corona10:no-issue-remove-compiler-warn

Conversation

@corona10

@corona10corona10 commented May 14, 2023

Copy link
Copy Markdown
Member

I noticed the warn while I built CPython with GCC8 + PGO + LTO.


gcc -pthread -c -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O3 -Wall -fno-semantic-interposition -flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none -g -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration -fvisibility=hidden -fprofile-use -fprofile-correction -I./Include/internal -I. -I./Include -DPy_BUILD_CORE -o Python/bltinmodule.o Python/bltinmodule.c
Python/assemble.c: In function ‘_PyAssemble_MakeCodeObject’:
Python/assemble.c:131:8: warning: ‘handler.h_preserve_lasti’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (handler->h_preserve_lasti) {
^
Python/assemble.c:147:34: note: ‘handler.h_preserve_lasti’ was declared here
_PyCompile_ExceptHandlerInfo handler;
^~~~~~~
Python/assemble.c:132:15: warning: ‘handler.h_startdepth’ may be used uninitialized in this function [-Wmaybe-uninitialized]
depth -= 1;
~~~~~~^~~~
Python/assemble.c:147:34: note: ‘handler.h_startdepth’ was declared here
_PyCompile_ExceptHandlerInfo handler;
^~~~~~~

@corona10corona10 changed the title no-issue: Remove gcc compiler warn for may be used uninitializedno-issue: Remove gcc compiler warn for assemble.cMay 14, 2023
@corona10

Copy link
Copy Markdown
MemberAuthor

Tests / Hypothesis Tests on Ubuntu (pull_request)

Unrelated to this PR: #22863 (comment)

@iritkatrieliritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@iritkatrieliritkatriel changed the title no-issue: Remove gcc compiler warn for assemble.cgh-87092: avoid gcc warning on uninitialized struct field in assemble.cMay 14, 2023
@iritkatriel
iritkatriel merged commit 178153c into python:mainMay 14, 2023
@corona10
corona10 deleted the no-issue-remove-compiler-warn branch May 14, 2023 11:32
carljm added a commit to carljm/cpython that referenced this pull request May 15, 2023
* main: (29 commits)
pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
pythongh-101819: Isolate `_io` (python#101948)
Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
pythongh-104490: Consistently define phony make targets (python#104491)
pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
pythongh-101282: move BOLT config after PGO (pythongh-104493)
pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
pythongh-104337: Clarify random.gammavariate doc entry (python#104410)
Minor improvements to typing docs (python#104465)
pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
...
carljm added a commit to carljm/cpython that referenced this pull request May 15, 2023
* main: (204 commits)
pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
pythongh-101819: Isolate `_io` (python#101948)
Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
pythongh-104490: Consistently define phony make targets (python#104491)
pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
pythongh-101282: move BOLT config after PGO (pythongh-104493)
pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
pythongh-104337: Clarify random.gammavariate doc entry (python#104410)
Minor improvements to typing docs (python#104465)
pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@iritkatriel@bedevere-bot