Skip to content

gh-104876: Remove deprecated turtle.RawTurtle.settiltangle - #104877

Merged
hugovk merged 5 commits into
python:mainfrom
hugovk:rm-turtle-settiltangle
May 26, 2023
Merged

gh-104876: Remove deprecated turtle.RawTurtle.settiltangle#104877
hugovk merged 5 commits into
python:mainfrom
hugovk:rm-turtle-settiltangle

Conversation

@hugovk

@hugovkhugovk commented May 24, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Closes#104876.

Remove the turtle.RawTurtle.settiltangle method, deprecated in docs since Python 3.1 and with a warning since Python 3.11.

📚 Documentation preview 📚: https://cpython-previews--104877.org.readthedocs.build/

@hugovkhugovk added 3.13 bugs and security fixes and removed awaiting core review labels May 24, 2023
@hugovkhugovk changed the title Remove deprecated turtle.RawTurtle.settiltanglegh-104876: Remove deprecated turtle.RawTurtle.settiltangleMay 24, 2023
@bedevere-botbedevere-bot mentioned this pull request May 24, 2023
Closed
@hugovkhugovk added the stdlib Standard Library Python modules in the Lib/ directory label May 25, 2023
@hugovkhugovk mentioned this pull request May 25, 2023
Merged
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes

@vstinnervstinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I left minor remarks. Also, I never used the turtle module, so I don't know how to test this change. Lib/test/test_turtle.py checks that there is no regression, no?

Comment threadLib/turtle.py Outdated
Comment threadDoc/whatsnew/3.13.rst Outdated
hugovkand others added 3 commits May 25, 2023 19:16
@hugovk@vstinner
Improve wording
dd17c3e
Co-authored-by: Victor Stinner <vstinner@python.org>
@hugovk
Remove outdated comment
df25c04
@hugovk
Improve wording
e0fdf63
vstinner
vstinner approved these changes May 25, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovk
hugovk merged commit 10c4583 into python:mainMay 26, 2023
@hugovk
hugovk deleted the rm-turtle-settiltangle branch May 26, 2023 04:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

3.13bugs and security fixesstdlibStandard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated turtle.RawTurtle.settiltangle method

3 participants

@hugovk@vstinner@bedevere-bot