Skip to content

gh-104773: PEP 594: Remove the audioop module - #104937

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_audioop
May 25, 2023
Merged

gh-104773: PEP 594: Remove the audioop module#104937
vstinner merged 1 commit into
python:mainfrom
vstinner:remove_audioop

Conversation

@vstinner

@vstinnervstinner commented May 25, 2023

Copy link
Copy Markdown
Member

@vstinner

Copy link
Copy Markdown
MemberAuthor

hugovk approved these changes

Thanks a lot @hugovk for all your precious reviews!!!

@hugovk

Copy link
Copy Markdown
Member

Thanks for the PRs!

I'll trade you for some reviews on #104816, #104877 and #104887 :)

@vstinner
vstinner merged commit f66be6b into python:mainMay 25, 2023
@vstinner
vstinner deleted the remove_audioop branch May 25, 2023 15:59
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Windows 3.x has failed when building commit f66be6b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/729/builds/4577) and take a look at the build logs.
  4. Check if the failure is related to this commit (f66be6b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/729/builds/4577

Failed tests:

  • test_subprocess

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

414 tests OK.

10 slowest tests:

  • test_math: 6 min 36 sec
  • test_multiprocessing_spawn: 4 min 31 sec
  • test_tokenize: 2 min 25 sec
  • test_unparse: 2 min 20 sec
  • test_tarfile: 2 min 3 sec
  • test_capi: 2 min
  • test_concurrent_futures: 1 min 50 sec
  • test_unicodedata: 1 min 44 sec
  • test_fstring: 1 min 43 sec
  • test_compileall: 1 min 42 sec

35 tests skipped:
test.test_asyncio.test_unix_events test_curses test_dbm_gnu
test_dbm_ndbm test_devpoll test_epoll test_fcntl test_fork1
test_gdb test_grp test_ioctl test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_openpty test_peg_generator
test_perf_profiler test_perfmaps test_poll test_posix test_pty
test_pwd test_readline test_resource test_syslog
test_threadsignals test_tix test_tkinter test_ttk test_wait3
test_wait4 test_xxlimited test_xxtestfuzz test_zipfile64
test_zoneinfo

1 re-run test:
test_subprocess

Total duration: 24 min 24 sec

Click to see traceback logs
Traceback (most recent call last):
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 480, in temp_diryield path
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 533, in temp_cwdyield cwd_dir
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\libregrtest\main.py", line 738, in mainself._main(tests, kwargs)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\libregrtest\main.py", line 797, in _main
sys.exit(0)
SystemExit: 0
Traceback (most recent call last):
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\runpy.py", line 198, in _run_module_as_mainreturn _run_code(code, main_globals, None,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\runpy.py", line 88, in _run_codeexec(code, run_globals)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\__main__.py", line 2, in <module>
main()
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\libregrtest\main.py", line 802, in main
Regrtest().main(tests=tests, **kwargs)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\libregrtest\main.py", line 732, in mainwith os_helper.temp_cwd(test_cwd, quiet=True):
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\contextlib.py", line 155, in __exit__self.gen.throw(value)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 531, in temp_cwdwith temp_dir(path=name, quiet=quiet) as temp_path:
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\contextlib.py", line 155, in __exit__self.gen.throw(value)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 485, in temp_dir
rmtree(path)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 442, in rmtree
_rmtree(path)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 385, in _rmtree
_waitfor(_rmtree_inner, path, waitall=True)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 330, in _waitfor
func(pathname)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\os_helper.py", line 382, in _rmtree_inner
_force_run(fullname, os.rmdir, fullname)
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\__init__.py", line 218, in _force_runreturn func(*args)
^^^^^^^^^^^PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Workspace\\buildarea\\3.x.linaro-win-arm64\\build\\build\\test_python_1260�\\test_python_worker_5280�'
Traceback (most recent call last):
File "C:\Workspace\buildarea\3.x.linaro-win-arm64\build\Lib\test\support\__init__.py", line 207, in _force_runreturn func(*args)
^^^^^^^^^^^PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Workspace\\buildarea\\3.x.linaro-win-arm64\\build\\build\\test_python_1260�\\test_python_worker_5280�'

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@hugovk@bedevere-bot