Uh oh!
There was an error while loading. Please reload this page.
CI: Bump macOS build to use OpenSSL v3.0 - #105538
Conversation
erlend-aasland
commented
Jun 8, 2023
Not sure about how far we should backport this. I'll leave it to Ned :) |
ned-deily
commented
Jun 8, 2023
I think it should be the RM's call for each but, based on @gpshead's discussion elsewhere regarding OpenSSL's support policies, I think we definitely should backport to 3.11 and 3.10 and probably also 3.9 and 3.8, given that 1.1.x will be no longer supported before their EOLs. 3.7 should not be backported at the moment at least as all the changes to support 3.0 have not been backported to it and 3.7 is about to hit EOL anyway. Perhaps @pablogsal and @ambv have opinions? |
ned-deily
commented
Jun 8, 2023
There is one other related task: ensure that the all of the Homebrew OpenSSL versions we use in the GHA Workflows have been updated to the most recent releases. Last time I looked they weren't. |
erlend-aasland
commented
Jun 9, 2023
I added a step that upgrades only |
erlend-aasland
commented
Jun 9, 2023
Locally, Homebrew installs OpenSSL 3.0.9, but it seems stuck at v3.0.8 in CI. I tried to disable Perhaps @hugovk has a solution to this? |
hugovk
commented
Jun 9, 2023
Hmm, it's downloading from https://ghcr.io/ which is GitHub Packages, does GitHub have their own local cache and it doesn't yet have 3.0.9? https://github.com/python/cpython/actions/runs/5219127895/jobs/9420617810?pr=105538#step:4:22 Looks like Homebrew now defaults to a local mirror: https://docs.brew.sh/Installation#git-remote-mirroring Perhaps unsetting |
erlend-aasland
commented
Jun 9, 2023
Thanks, @hugovk. I tried adjusting the env vars again, also this time adding a |
erlend-aasland
commented
Jun 16, 2023
IMO, we should not let that block this PR. Unless others disagree, I propose to land this PR. |
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot
commented
Jun 16, 2023
GH-105867 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit 34e93d3) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
bedevere-bot
commented
Jun 16, 2023
GH-105868 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit 34e93d3) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
(cherry picked from commit 34e93d3) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
bedevere-bot
commented
Jun 16, 2023
GH-105869 is a backport of this pull request to the 3.10 branch. |
bedevere-bot
commented
Jun 16, 2023
GH-105871 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 34e93d3) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
bedevere-bot
commented
Jun 16, 2023
GH-105872 is a backport of this pull request to the 3.8 branch. |
…hon#105871) (cherry picked from commit 34e93d3) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
See gh-99079 and python/devguide#1112