Uh oh!
There was an error while loading. Please reload this page.
Bump macOS build recommendations to OpenSSL v3.0 - #1112
Merged
Conversation
1. removing references to 3.7 which will be end-of-life shortly and otherwise would require including OpenSSL 1.1.1 libs. 2. removing MacPorts recipe for 3.10 and earlier because there are conflicts with the use of --with-openssl and the use of CPPFLAGS/LDFLAGS.
ned-deily
left a comment
Member
There was a problem hiding this comment.
Thanks! I've pushed some changes to the PR. Rather than try to differentiate between OpenSSL 1.1.1 and 3.x, which would complicate things (like the brew installs) and since we want to get to 3.0 anyway, let's just bite the bullet here. I've also simplified the MacPorts recipes by removing the suggestion for 3.10 and earlier as that doesn't quite build correctly.
erlend-aasland
commented
Jun 9, 2023
ContributorAuthor
Thanks! |
erlend-aasland
commented
Jun 9, 2023
ContributorAuthor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1111
📚 Documentation preview 📚: https://cpython-devguide--1112.org.readthedocs.build/