Skip to content

GH-104584: Assorted fixes for the optimizer API. - #105683

Merged
markshannon merged 10 commits into
python:mainfrom
faster-cpython:fix-optimizer-api
Jun 19, 2023
Merged

GH-104584: Assorted fixes for the optimizer API.#105683
markshannon merged 10 commits into
python:mainfrom
faster-cpython:fix-optimizer-api

Conversation

@markshannon

@markshannonmarkshannon commented Jun 12, 2023•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fixes a few odds and ends found trying to fix#105682

@bedevere-botbedevere-bot mentioned this pull request Jun 12, 2023
Closed
carljm
carljm reviewed Jun 12, 2023
View reviewed changes
Comment threadLib/test/test_capi/test_misc.py Outdated
Comment threadLib/test/test_capi/test_misc.py Outdated
Comment threadLib/test/test_capi/test_misc.py Outdated
Comment threadPython/bytecodes.c
Comment threadPython/bytecodes.c Outdated
@brandtbucher
brandtbucher self-requested a review June 12, 2023 17:25
brandtbucher
brandtbucher reviewed Jun 13, 2023
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to all of @carljm's comments.

Comment threadObjects/codeobject.c Outdated
Comment threadPython/optimizer.c Outdated
Comment threadPython/optimizer.c
Comment threadPython/optimizer.c Outdated
carljm
carljm approved these changes Jun 15, 2023
View reviewed changes
Comment threadLib/test/test_capi/test_misc.py Outdated
@gvanrossum

gvanrossum commented Jun 18, 2023

Copy link
Copy Markdown
Member

What's holding this up? I was playing around with the optimizer, trying to bootstrap a "hello world" version of a Tier 2 interpreter, and I need this to avoid crashes at exit (crashes that happened even without my changes).

@markshannon
markshannon merged commit 5816199 into python:mainJun 19, 2023
@markshannon
markshannon deleted the fix-optimizer-api branch June 19, 2023 09:32
@AlexWaygoodAlexWaygood mentioned this pull request Jun 19, 2023
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Jun 19, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments
@carljmcarljmcarljm approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

./python -m test -v test_capi -m test_misc --forever fails.

5 participants

@markshannon@gvanrossum@carljm@brandtbucher@bedevere-bot