Uh oh!
There was an error while loading. Please reload this page.
gh-106320: Remove private PyLong C API functions - #108429
Merged
Merged
Conversation
Remove private PyLong C API functions: * _PyLong_AsByteArray() * _PyLong_DivmodNear() * _PyLong_Format() * _PyLong_Frexp() * _PyLong_FromByteArray() * _PyLong_FromBytes() * _PyLong_GCD() * _PyLong_Lshift() * _PyLong_Rshift() Move these functions to the internal C API. No longer export _PyLong_FromBytes() function.
vstinner
requested review from
1st1, berkerpeksag, corona10, erlend-aasland and rhettinger
as code ownersAugust 24, 2023 16:14
rhettinger
removed their request for review
August 24, 2023 16:30
vstinner
commented
Aug 24, 2023
MemberAuthor
@erlend-aasland: sqlite3 uses another private function, |
scoder
commented
Oct 20, 2023
Contributor
What is the intended replacement for |
scoder
commented
Oct 20, 2023
Contributor
What is the intended replacement for |
This was referenced Oct 20, 2023
MemberAuthor
I created PR #111140: C API: Consider adding public PyLong_AsByteArray() and PyLong_FromByteArray() functions.
I created PR #111139: C API: Consider adding a public PyLong_GCD() function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove private PyLong C API functions:
Move these functions to the internal C API. No longer export _PyLong_FromBytes() function.