Uh oh!
There was an error while loading. Please reload this page.
gh-108303: Move all inspect test files to test_inspect/ - #109607
Conversation
sobolevn
commented
Sep 20, 2023
Looks like there's one more hidden dependency: in |
vstinner
left a comment
There was a problem hiding this comment.
Can you please try with a first PR to move ready_to_import() to test.support?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| def load_tests(*args): | ||
| return support.load_package_tests(os.path.dirname(__file__), *args) |
There was a problem hiding this comment.
@serhiy-storchaka: It would be nice if we could magically generate such function, instead of having to duplicate the same 4 lines in each test_xxx/ test package. Do you think that it would be possible?
vstinner
commented
Sep 21, 2023
This change is LGTM, but I would to wait until #109626 is backported to 3.11. If the backport queue is too big, it becomes really complicated to handle it :-( |
sobolevn
commented
Oct 10, 2023
I've solved conflicts, it should be now good to go, since all backports are done. |
vstinner
commented
Oct 10, 2023
Before: After: Same number of tests: good. And tests pass :-) |
miss-islington
commented
Oct 10, 2023
miss-islington
commented
Oct 10, 2023
Sorry, @sobolevn and @vstinner, I could not cleanly backport this to |
miss-islington
commented
Oct 10, 2023
Sorry, @sobolevn and @vstinner, I could not cleanly backport this to |
vstinner
commented
Oct 10, 2023
@sobolevn: Thanks. I merged your PR. But the thing couldn't be backported automatically. Can you please try to backport the change manually to 3.12? |
bedevere-bot
commented
Oct 10, 2023
|
sobolevn
commented
Oct 10, 2023
Working on it. |
bedevere-bot
commented
Oct 10, 2023
|
pythonGH-109607) (cherry picked from commit 732532b) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
GH-110732 is a backport of this pull request to the 3.12 branch. |
GH-111543 is a backport of this pull request to the 3.11 branch. |
This PR also moves
ready_to_importhelper totest/support/import_helper, becausetest_inspectwas importingtest_import, which is not good at all.