Skip to content

gh-109625: Move _ready_to_import from test_import to import_helper - #109626

Merged
vstinner merged 1 commit into
python:mainfrom
sobolevn:issue-109625
Sep 21, 2023
Merged

gh-109625: Move _ready_to_import from test_import to import_helper#109626
vstinner merged 1 commit into
python:mainfrom
sobolevn:issue-109625

Conversation

@sobolevn

@sobolevnsobolevn commented Sep 20, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Sep 20, 2023
Closed
@sobolevnsobolevn added tests Tests in the Lib/test dir skip news labels Sep 20, 2023
vstinner
vstinner approved these changes Sep 21, 2023
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadLib/test/test_inspect.py
from test import inspect_stringized_annotations
from test import inspect_stringized_annotations_2

from test.test_import import _ready_to_import

@vstinnervstinnerSep 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, we should not make tests inter-dependents. This change goes to the right direction!

@vstinner
vstinner merged commit 115c49a into python:mainSep 21, 2023
@vstinner

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member

Merged, thanks. I just modified a little bit the commit message.

@sobolevn
sobolevn deleted the issue-109625 branch September 21, 2023 07:42
@sobolevn

sobolevn commented Sep 21, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks! I will rebase #109607 shortly.

@vstinnervstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 21, 2023
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 115c49ad5a5ccfb628fef3ae06a566f7a0197f97 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2023
@sobolevn@miss-islington
pythongh-109625: Move _ready_to_import() from test_import to support.…
1e40c02
…import_helper (pythonGH-109626)
(cherry picked from commit 115c49a)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented Sep 21, 2023

Copy link
Copy Markdown

GH-109640 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Sep 21, 2023
@vstinner

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member

@sobolevn: Can you please backport this change to the 3.11 branch? I was told to backport all test refactoring changes to stable branches: #108303 (comment)

@vstinnervstinner mentioned this pull request Sep 21, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 22, 2023
@sobolevn
[3.11]pythongh-109625: Move _ready_to_import() from test_import to s…
752e96f
…upport.import_helper (pythonGH-109626).
(cherry picked from commit 115c49a)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-appBot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109718 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
@sobolevn

sobolevn commented Sep 22, 2023

Copy link
Copy Markdown
MemberAuthor

Done!

vstinner pushed a commit that referenced this pull request Sep 22, 2023
@sobolevn
[3.11]gh-109625: Move _ready_to_import() from test_import to support…
f45ef5e
….import_helper (GH-109626) (#109718)
[3.11] gh-109625: Move _ready_to_import() from test_import to support.import_helper (GH-109626).
(cherry picked from commit 115c49a)
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@sobolevn@csm10495
pythongh-109625: Move _ready_to_import() from test_import to support.…
4806a15
…import_helper (python#109626)
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington@sobolevn
[3.12]gh-109625: Move _ready_to_import() from test_import to support…
8c5fd21
….import_helper (GH-109626) (#109640)
gh-109625: Move _ready_to_import() from test_import to support.import_helper (GH-109626)
(cherry picked from commit 115c49a)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn@Glyphack
pythongh-109625: Move _ready_to_import() from test_import to support.…
33a6b9e
…import_helper (python#109626)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes
@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner
@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner
@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

@vstinnervstinner

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@vstinner@miss-islington