Uh oh!
There was an error while loading. Please reload this page.
GH-110793: add GitHub Actions job that runs tests after installing - #110794
GH-110793: add GitHub Actions job that runs tests after installing#110794FFY00 wants to merge 6 commits into
Conversation
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
commented
Oct 13, 2023
The job is now successful, this is ready for review. I'd still wait a little bit before merging, to see if there is any discussion on the issue. |
Signed-off-by: Filipe Laíns <lains@riseup.net>
| --with-openssl-rpath | ||
| - name: Build CPython out-of-tree | ||
| working-directory: ${{ env.CPYTHON_BUILDDIR }} | ||
| run: make -j4 |
There was a problem hiding this comment.
I think that's the number of threads for Linux and Windows.
In this PR, I just copied the other jobs, so this comes from there. We can do the improvements you are suggesting (would also be nicer when running locally with act for eg), but it should probably be in a different PR.
hugovk
commented
Oct 15, 2023
If we go for this, let's do them as reusable workflows: Examples:
Possibly also |
hugovk
commented
Oct 15, 2023
I noticed Let's try adding them to the new job.
Agreed. Do you want to implement that in this PR or in a followup one? |
hugovk
commented
Oct 16, 2023
It would be good in this PR. |
This PR is stale because it has been open for 30 days with no activity. |



Uh oh!
There was an error while loading. Please reload this page.