Uh oh!
There was an error while loading. Please reload this page.
gh-110793: Add CI job that runs tests with an installed build - #152664
Open
StanFromIreland wants to merge 7 commits into
Open
gh-110793: Add CI job that runs tests with an installed build#152664StanFromIreland wants to merge 7 commits into
StanFromIreland wants to merge 7 commits into
Conversation
StanFromIreland
requested review from
AA-Turner, JacobCoffee, ezio-melotti, hugovk, itamaro and webknjaz
as code ownersJune 30, 2026 09:52
MemberAuthor
This is currently blocked by #152653 (failing |
| run: make install | ||
| - name: Set installed interpreter | ||
| run: | | ||
| ldversion=$(./python -c 'import sysconfig; print(sysconfig.get_config_var("LDVERSION"))') |
Member
There was a problem hiding this comment.
Suggested change
| ldversion=$(./python -c 'import sysconfig; print(sysconfig.get_config_var("LDVERSION"))') | |
| ldversion="$(./python -c 'import sysconfig; print(sysconfig.get_config_var("LDVERSION"))')" |
MemberAuthor
There was a problem hiding this comment.
Bash doesn’t split words on the RHS of an assignment. See this discussion for more information.
StanFromIreland
commented
Aug 7, 2026
MemberAuthor
Hi! Anyone have any comments on this? |
webknjaz
approved these changes
Aug 7, 2026
webknjaz
left a comment
Member
There was a problem hiding this comment.
Looks good in general. I have an inline question, though. Non-blocking.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes into consideration the suggestions on #110794.
As for timing, I picked the fastest runner available, we'll have to see how long it takes. I presume it won't be slower than the Windows builds, however.Looking at the three runs on this PR, it takes about nine minutes (however, that does include two 30s timeouts). That's far faster then our longest runs which are around half an hour.