Skip to content

gh-111673: Refactor test_float/complex.py (split out support classes) - #110956

Closed
skirpichev wants to merge 20 commits into
python:mainfrom
skirpichev:refactor-fc-tests
Closed

gh-111673: Refactor test_float/complex.py (split out support classes)#110956
skirpichev wants to merge 20 commits into
python:mainfrom
skirpichev:refactor-fc-tests

Conversation

@skirpichev

@skirpichevskirpichev commented Oct 17, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

First commit mostly taken from #26827, second - some simple extension of this. @serhiy-storchaka

serhiy-storchakaand others added 2 commits October 17, 2023 06:30
@serhiy-storchaka@skirpichev
Refactor test_float/complex.py
ddc670b
Taken from python#26827
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@skirpichev
A continuation: factor out Complex/FloatLikeSubclass'es
944de07
@bedevere-appbedevere-appBot added awaiting review tests Tests in the Lib/test dir labels Oct 17, 2023
@skirpichevskirpichev mentioned this pull request Nov 2, 2023
Merged
@skirpichevskirpichev changed the title Refactor test_float/complex.py (split out support classes)gh-111673: Refactor test_float/complex.py (split out support classes)Nov 3, 2023
@bedevere-appbedevere-appBot mentioned this pull request Nov 3, 2023
Closed
@skirpichev
skirpichev marked this pull request as draft November 3, 2023 10:02
@skirpichev
skirpichev marked this pull request as ready for review November 4, 2023 03:47
@skirpichev

This comment was marked as resolved.

Sign in to view
@AlexWaygood

AlexWaygood commented Nov 4, 2023

Copy link
Copy Markdown
Member

@AlexWaygood, does this require news? I think - not.

Yeah, we can skip it for this one, good call

@skirpichev
skirpichev marked this pull request as draft December 3, 2023 02:51
@skirpichev

This comment was marked as outdated.

Sign in to view
@skirpichevskirpichev mentioned this pull request May 28, 2024
Merged
@skirpichev
skirpichev marked this pull request as ready for review June 1, 2024 02:12
@skirpichev

skirpichev commented Jul 4, 2024

Copy link
Copy Markdown
MemberAuthor

@sobolevn, maybe you can review this as an issue author? Let me know if it's better to split this to several pull requests.

@skirpichevskirpichev added the needs backport to 3.13 bugs and security fixes label Apr 17, 2025
@skirpichev

skirpichev commented Apr 17, 2025

Copy link
Copy Markdown
MemberAuthor

CC @vstinner

vstinner
vstinner reviewed Apr 17, 2025
View reviewed changes
Comment threadLib/test/support/classes.py Outdated
vstinner
vstinner reviewed Apr 17, 2025
View reviewed changes

@vstinnervstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that I like this change. It changes a lot of tests for little value (it's just refactoring). But I'm not against this change.

@serhiy-storchaka: Do you have an opinion on this change?

Comment threadLib/test/support/number_helper.py
class FloatSubclass(float):
pass

class OtherFloatSubclass(float):

@vstinnervstinnerApr 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's worth it to have OtherFloatSubclass and OtherComplexSubclass in this number_helper module.

@serhiy-storchaka

serhiy-storchaka commented Apr 17, 2025

Copy link
Copy Markdown
Member

I already proposed something similar in #84310. But it only defined classes with a single special method (__index__, __float__), which could be used in a number of tests. I am not sure that it is worth to share simple or too specialized classes like IntSubclass or WithIntAndIndex.

@skirpichev

skirpichev commented Apr 17, 2025

Copy link
Copy Markdown
MemberAuthor

Ok, thanks.

I think, I haven't enough motivation to push it further.

@skirpichev
skirpichev deleted the refactor-fc-tests branch April 17, 2025 23:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

Assignees

No one assigned

Labels

awaiting reviewneeds backport to 3.13bugs and security fixesskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skirpichev@AlexWaygood@serhiy-storchaka@vstinner