Uh oh!
There was an error while loading. Please reload this page.
gh-111495: Add tests for PyFloat C API - #111624
Conversation
skirpichev
commented
Nov 2, 2023
Some C API tests for floats are in cpython/Lib/test/test_float.py Lines 1518 to 1569 in ed587be In this PR this left intact, but maybe we should move them. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sobolevn
left a comment
There was a problem hiding this comment.
Just one suggestion :)
All other things LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
skirpichev
commented
Nov 4, 2023
Converted to a draft per review #111591 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM.
Thank you @skirpichev for your contribution and for your fast response.
Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
(cherry picked from commit b452202) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
GH-111752 is a backport of this pull request to the 3.12 branch. |
skirpichev
commented
Nov 6, 2023
@serhiy-storchaka, thank you for review. |
Uh oh!
There was an error while loading. Please reload this page.