Skip to content

Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET - #110963

Merged
hugovk merged 1 commit into
python:mainfrom
tonybaloney:patch-3
Oct 23, 2023
Merged

Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET#110963
hugovk merged 1 commit into
python:mainfrom
tonybaloney:patch-3

Conversation

@tonybaloney

@tonybaloneytonybaloney commented Oct 17, 2023•
edited by hugovk
Loading

Copy link
Copy Markdown
Contributor

Trivial change.

METH_FASTCALL was added in 3.7, vector call came in 3.8.

The macro PY_VECTORCALL_ARGUMENTS_OFFSET doesn't have the version added (it was 3.8)

📚 Documentation preview 📚: https://cpython-previews--110963.org.readthedocs.build/

@bedevere-appbedevere-appBot added awaiting review docs Documentation in the Doc dir skip news labels Oct 17, 2023
@hugovkhugovk changed the title Add a version added note for PY_VECTORCALL_ARGUMENT_OFFSETAdd a version added note for PY_VECTORCALL_ARGUMENTS_OFFSETOct 23, 2023
@hugovkhugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
hugovk
hugovk approved these changes Oct 23, 2023
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed added in 3.8 in PR #13185. Thank you!

@hugovk
hugovk merged commit be551a7 into python:mainOct 23, 2023
@miss-islington-app

miss-islington-appBot commented Oct 23, 2023

Copy link
Copy Markdown

Thanks @tonybaloney for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2023
@tonybaloney@miss-islington
Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET (pythonGH…
80958a4
…-110963)
(cherry picked from commit be551a7)
Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
@bedevere-app

bedevere-appBot commented Oct 23, 2023

Copy link
Copy Markdown

GH-111219 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2023
@tonybaloney@miss-islington
Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET (pythonGH…
aacc034
…-110963)
(cherry picked from commit be551a7)
Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Oct 23, 2023
@bedevere-app

bedevere-appBot commented Oct 23, 2023

Copy link
Copy Markdown

GH-111220 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.11 only security fixes label Oct 23, 2023
hugovk pushed a commit that referenced this pull request Oct 23, 2023
@miss-islington@tonybaloney
[3.11] Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET (G…
09bd752
…H-110963) (#111220)
Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
hugovk pushed a commit that referenced this pull request Oct 23, 2023
@miss-islington@tonybaloney
[3.12] Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET (G…
87123ab
…H-110963) (#111219)
Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@tonybaloney@aisk
Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET (python#1…
85248e7
…10963)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@tonybaloney@Glyphack
Add a version added note for PY_VECTORCALL_ARGUMENTS_OFFSET (python#1…
1dd3fc1
…10963)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonybaloney@hugovk@AlexWaygood