Uh oh!
There was an error while loading. Please reload this page.
bpo-36974: PEP 590 - #13185
Conversation
025d6d4 to
746c2afCompare4ea6af5 to
aa440ccCompared9a1bd8 to
ac4da56Compare…ctions Test functions are renamed to reflect the C API they're testing.
encukou
commented
May 29, 2019
I went through the code, and made a few small changes. Do they look OK to you? |
I don't agree with 7536e69 for two reasons:
|
| from types import MethodType | ||
| from functools import partial | ||
| def vectorcall(func, args, kwargs=None): |
There was a problem hiding this comment.
If you want to set a default for kwargs, it should be kwargs={}.
| def test_vectorcall(self): | ||
| # Test a bunch of different ways to call objects: | ||
| # 1. normal call | ||
| # 2. vectorcall |
There was a problem hiding this comment.
It would be good to fix this comment, as you're adding a new way of testing the call.
jdemeyer
commented
May 29, 2019
No further comments. |
encukou
commented
May 29, 2019
via email
I'm not entirely convinced on the recursivecall, but it's probably OK to leave out.
I'm out for a couple of hours. Could you push a revert and your suggested changes to get the CI going? …On May 29, 2019 5:17:12 PM GMT+02:00, Jeroen Demeyer ***@***.***> wrote:
No further comments.
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
#13185 (comment) -- Sent from my Android device with K-9 Mail. Please excuse my brevity. |
bedevere-bot
commented
May 29, 2019
|
bedevere-bot
commented
May 29, 2019
|
bedevere-bot
commented
May 29, 2019
|
encukou
commented
May 29, 2019
Oh! |
bedevere-bot
commented
May 29, 2019
|
bedevere-bot
commented
May 29, 2019
|
encukou
commented
May 29, 2019
All buildbots are green now. Thank you, @jdemeyer and @markshannon, for putting this together! Docs should come in early beta. |
jdemeyer
commented
May 30, 2019
Petr, thank you for reviewing and merging and in particular fixing the buildbot failure. About follow-ups:
The others are less important and can wait. |
Co-authored-by: Jeroen Demeyer <J.Demeyer@UGent.be> Co-authored-by: Mark Shannon <mark@hotpy.org>
Implementation of PEP 590 by Mark Shannon and Jeroen Demeyer.
CC @encukou@markshannon
https://bugs.python.org/issue36974