Skip to content

GH-111062: Apply reusable workflow for the Linux CI - #111440

Closed
NCLI wants to merge 8 commits into
python:mainfrom
NCLI:no-gil-workflow
Closed

GH-111062: Apply reusable workflow for the Linux CI#111440
NCLI wants to merge 8 commits into
python:mainfrom
NCLI:no-gil-workflow

Conversation

@NCLI

@NCLINCLI commented Oct 29, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@ghost

ghost commented Oct 29, 2023•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
Comment thread.github/workflows/build.yml Outdated
- name: Remount sources writable for tests
# some tests write to srcdir, lack of pyc files slows down testing
run: sudo mount $CPYTHON_RO_SRCDIR -oremount,rw
- name: Tests

@corona10corona10Oct 29, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we don't need to run test code at this moment :)

@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@NCLINCLI changed the title No gil workflowGH-111062 No gil workflow for CI/CDOct 29, 2023
@bedevere-appbedevere-appBot mentioned this pull request Oct 29, 2023
Closed
@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@corona10corona10 changed the title GH-111062 No gil workflow for CI/CDGH-111062: Apply Reusable workflow for the Linux CIOct 29, 2023
@corona10corona10 changed the title GH-111062: Apply Reusable workflow for the Linux CIGH-111062: Apply reusable workflow for the Linux CIOct 29, 2023
@dimaqq

dimaqq commented Oct 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Is this superseded by #111446 now?

@dimaqq

dimaqq commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

"nogil" -> "free-threaded"
let's build this on top of #111446

@corona10

corona10 commented Oct 30, 2023

Copy link
Copy Markdown
Member

Duplicated with #111452

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 left review comments
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

No one assigned

Labels

awaiting reviewDO-NOT-MERGEskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NCLI@dimaqq@corona10