Skip to content

gh-111062: Separate linux build into a reusable workflow - #111446

Closed
NCLI wants to merge 19 commits into
python:mainfrom
NCLI:reusable_ubuntu_build
Closed

gh-111062: Separate linux build into a reusable workflow#111446
NCLI wants to merge 19 commits into
python:mainfrom
NCLI:reusable_ubuntu_build

Conversation

@NCLI

@NCLINCLI commented Oct 29, 2023•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app

bedevere-appBot commented Oct 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-appbedevere-appBot mentioned this pull request Oct 29, 2023
Closed
@bedevere-app

This comment was marked as resolved.

Sign in to view
dimaqq
dimaqq reviewed Oct 29, 2023
View reviewed changes
Comment thread.github/workflows/reusable-build-ubuntu.yml Outdated
@@ -0,0 +1,84 @@
name: Tests

@dimaqqdimaqqOct 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

dimaqq
dimaqq reviewed Oct 29, 2023
View reviewed changes
Comment thread.github/workflows/reusable-build-ubuntu.yml Outdated
contents: read

jobs:
name: 'Ubuntu reusable'

@dimaqqdimaqqOct 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

@NCLINCLI changed the title GH-111062 Reusable ubuntu workflowfor build testGH-111062 Separate linux build into a reusable workflowOct 29, 2023
dimaqq
dimaqq approved these changes Oct 29, 2023
View reviewed changes

@dimaqqdimaqq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 😄

@NCLI
NCLI marked this pull request as ready for review October 29, 2023 07:00
@NCLI
NCLI requested a review from hugovk as a code ownerOctober 29, 2023 07:00
@dimaqqdimaqq mentioned this pull request Oct 29, 2023
Closed
@hugovkhugovk changed the title GH-111062 Separate linux build into a reusable workflowgh-111062: Separate linux build into a reusable workflowOct 29, 2023
@hugovk

hugovk commented Oct 29, 2023

Copy link
Copy Markdown
Member

Looking good, let's first decide on the name, re: #111062 (comment)

reusable-build-ubuntu.yml, or reusable-ubuntu.yml to match reusable-docs.yml?

@corona10

corona10 commented Oct 30, 2023

Copy link
Copy Markdown
Member

Duplicated with #111452

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner
1 more reviewer
@dimaqqdimaqqdimaqq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@hugovkhugovk

Labels

awaiting reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NCLI@hugovk@corona10@dimaqq