Skip to content

gh-111765: move old PyFloat_* tests to Lib/test/test_capi/test_float.py - #111766

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
skirpichev:move-pack-unpack-tests-111765
Nov 7, 2023
Merged

gh-111765: move old PyFloat_* tests to Lib/test/test_capi/test_float.py #111766
serhiy-storchaka merged 2 commits into
python:mainfrom
skirpichev:move-pack-unpack-tests-111765

Conversation

@skirpichev

@skirpichevskirpichev commented Nov 6, 2023

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot added the tests Tests in the Lib/test dir label Nov 6, 2023
@skirpichev

Copy link
Copy Markdown
MemberAuthor

@AlexWaygood, probably this also can skip news?

@skirpichev

Copy link
Copy Markdown
MemberAuthor

CC @serhiy-storchaka

@serhiy-storchakaserhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was going to suggest you make these changes, but it was obvious, so you already made them.

@miss-islington-app

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2023
…float.py (pythonGH-111766)
(cherry picked from commit a077b2f)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app

Copy link
Copy Markdown

GH-111818 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Nov 7, 2023
@skirpichev
skirpichev deleted the move-pack-unpack-tests-111765 branch November 7, 2023 11:51
@skirpichev

Copy link
Copy Markdown
MemberAuthor

I was going to suggest you make these changes

That was actually suggested in #111624.

serhiy-storchaka pushed a commit that referenced this pull request Nov 7, 2023
…_float.py (GH-111766) (GH-111818)
(cherry picked from commit a077b2f)
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev@serhiy-storchaka@AlexWaygood