Skip to content

gh-113317, Argument Clinic: Add Clinic.fail() method - #115371

Closed
vstinner wants to merge 3 commits into
python:mainfrom
vstinner:ac_clinic
Closed

gh-113317, Argument Clinic: Add Clinic.fail() method#115371
vstinner wants to merge 3 commits into
python:mainfrom
vstinner:ac_clinic

Conversation

@vstinner

@vstinnervstinner commented Feb 12, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • Add Clinic.fail() and Clinic.warn() methods.
  • Language.render(): clinic argument is now mandatory (fix type hint).
  • Replace some fail() and warn() calls with Clinic.fail() and Clinic.warn().

@vstinner
pythongh-113317, Argument Clinic: Add Clinic.fail() method
5b14469
* Add Clinic.fail() and Clinic.warn() methods.
* Language.render(): clinic argument is now mandatory (fix type
hint).
* Replace some fail() and warn() calls with Clinic.fail() and
Clinic.warn().
@bedevere-appbedevere-appBot mentioned this pull request Feb 12, 2024
Closed
erlend-aasland
erlend-aasland reviewed Feb 14, 2024
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
erlend-aasland
erlend-aasland reviewed Feb 14, 2024
View reviewed changes
Comment threadTools/clinic/clinic.py Outdated
vstinnerand others added 2 commits February 14, 2024 22:59
@vstinner@erlend-aasland
Update Tools/clinic/clinic.py
fa9bc96
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@vstinner@erlend-aasland
Update Tools/clinic/clinic.py
185f284
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@vstinner

vstinner commented Feb 14, 2024

Copy link
Copy Markdown
MemberAuthor

Does not this work?

This PR comes from my other PR which removes fail(). But let's move step by step, you're right.

@erlend-aaslanderlend-aasland mentioned this pull request Feb 15, 2024
Merged
@erlend-aasland

erlend-aasland commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

Obsoleted by #115510

@vstinner
vstinner deleted the ac_clinic branch February 15, 2024 14:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

Assignees

No one assigned

Labels

awaiting core reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@erlend-aasland