Skip to content

gh-113317: Argument Clinic: don't use global state in warn() and fail() - #115510

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/get-rid-of-global-clinic-in-fail-and-warn
Feb 15, 2024
Merged

gh-113317: Argument Clinic: don't use global state in warn() and fail()#115510
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:clinic/get-rid-of-global-clinic-in-fail-and-warn

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Feb 15, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-appbedevere-appBot mentioned this pull request Feb 15, 2024
Closed
sobolevn
sobolevn reviewed Feb 15, 2024
View reviewed changes
Comment threadTools/clinic/clinic.py
sobolevn
sobolevn approved these changes Feb 15, 2024
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erlend-aasland
erlend-aasland merged commit 7f074a7 into python:mainFeb 15, 2024
@erlend-aasland
erlend-aasland deleted the clinic/get-rid-of-global-clinic-in-fail-and-warn branch February 15, 2024 12:22
@erlend-aasland

erlend-aasland commented Feb 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review!

This was referenced Feb 15, 2024
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland@sobolevn