Uh oh!
There was an error while loading. Please reload this page.
gh-118263: Generalize path_t for C level optimizations - #118355
Conversation
nineteendo
commented
Apr 28, 2024
@eryksun, I wasn't able to use this for I was able to speed up |
nineteendo
commented
Apr 28, 2024
I think you'll be particularly pleased with this addition (I don't know why we didn't do this earlier): Lines 5564 to 5569 in 19209c6 |
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eryksun
commented
May 3, 2024
The converter could set a flag in the
This change shouldn't affect anything compatibility-wise, and if so that needs to be addressed. It's support code for CPython. I think it could be added to beta 2 this month if it misses beta 1. |
Uh oh!
There was an error while loading. Please reload this page.
I added a suppress option, which tells argument clinic you would like to handle errors manually, otherwise |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@eryksun, could you add backport labels? I also want to backport it to 3.12 (with the necessary changes) to use for |
nineteendo
commented
May 22, 2024
Thanks, do you think this looks ready? |
zooba
left a comment
There was a problem hiding this comment.
Love it! path_t might be my favourite thing about argument clinic, so great to see it getting even better.
One question and one comment below.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…type) in posixmodule (pythonGH-118355) (cherry picked from commit 96b392d) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Sorry, @nineteendo and @zooba, I could not cleanly backport this to |
GH-119513 is a backport of this pull request to the 3.13 branch. |
bedevere-bot
commented
May 24, 2024
|
bedevere-bot
commented
May 24, 2024
|
bedevere-bot
commented
May 24, 2024
|
bedevere-bot
commented
May 24, 2024
|
bedevere-bot
commented
May 24, 2024
|
nineteendo
commented
May 24, 2024
No issue, the buildbots simply ran out of space. |
…type) in posixmodule (pythonGH-118355)
GH-119608 is a backport of this pull request to the 3.12 branch. |
…type) in posixmodule (pythonGH-118355)
Benchmark:
ntpath.py
script
Note: no difference for
ntpath.is*(),ntpath.exists()&ntpath.lexists().posixpath.py
script
path_tfor C level optimizations #118263