Skip to content

gh-119146: Update paths in jit.yml - #119147

Merged
brandtbucher merged 7 commits into
python:mainfrom
savannahostrowski:jit-ignore-filews
May 19, 2024
Merged

gh-119146: Update paths in jit.yml#119147
brandtbucher merged 7 commits into
python:mainfrom
savannahostrowski:jit-ignore-filews

Conversation

@savannahostrowski

@savannahostrowskisavannahostrowski commented May 18, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request May 18, 2024
Closed
@brandtbucherbrandtbucher added tests Tests in the Lib/test dir skip news labels May 18, 2024
@brandtbucherbrandtbucher self-assigned this May 18, 2024
FFY00
FFY00 approved these changes May 18, 2024
View reviewed changes

@FFY00FFY00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually be able to ignore Python/perf_jit_trampoline.c by using a negative matching pattern: !Python/perf_jit_trampoline.c.

Other than that, looks good to me.

@savannahostrowski

savannahostrowski commented May 18, 2024

Copy link
Copy Markdown
MemberAuthor

Oh! I totally didn't know about that. I'll take a look at adding that when I also add .h files to the paths (since I missed adding those in too).

AlexWaygood
AlexWaygood reviewed May 18, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe we could just ignore all .md and .ini files? Then if we added others in the future, we wouldn't have to remember to update this file?

Comment thread.github/workflows/jit.yml Outdated
Comment thread.github/workflows/jit.yml Outdated
savannahostrowskiand others added 2 commits May 18, 2024 15:29
@savannahostrowski@AlexWaygood
Update jit.yml
bf52b3c
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@savannahostrowski@AlexWaygood
Update jit.yml
168bfd0
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@savannahostrowski

savannahostrowski commented May 18, 2024

Copy link
Copy Markdown
MemberAuthor

Yeah, that's a fair callout!

AlexWaygood
AlexWaygood approved these changes May 18, 2024
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

brandtbucher
brandtbucher reviewed May 19, 2024
View reviewed changes
Comment thread.github/workflows/jit.yml Outdated
@AlexWaygood@brandtbucher
Update .github/workflows/jit.yml
ce42693
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@brandtbucher
brandtbucher enabled auto-merge (squash) May 19, 2024 12:36
@brandtbucher
brandtbucher merged commit 5307f44 into python:mainMay 19, 2024
@hugovk

hugovk commented May 20, 2024

Copy link
Copy Markdown
Member

Thanks for the PR!

Shall we backport it, or close the issue?

@erlend-aasland

erlend-aasland commented May 20, 2024

Copy link
Copy Markdown
Contributor

I think it's ok to backport it to 3.13.

@brandtbucherbrandtbucher added the needs backport to 3.13 bugs and security fixes label May 20, 2024
@miss-islington-app

miss-islington-appBot commented May 20, 2024

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@savannahostrowski@AlexWaygood@miss-islington
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
80ff420
(cherry picked from commit 5307f44)
Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app

bedevere-appBot commented May 20, 2024

Copy link
Copy Markdown

GH-119226 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
This was referenced Jun 12, 2024
Merged
Merged
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@savannahostrowski@AlexWaygood@estyxx
pythonGH-119146: Don't run JIT CI on unrelated changes (pythonGH-119147)
be0335d
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@savannahostrowski
savannahostrowski deleted the jit-ignore-filews branch September 27, 2024 16:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes
@FFY00FFY00FFY00 approved these changes
@hugovkhugovkAwaiting requested review from hugovk

Assignees

@brandtbucherbrandtbucher

Labels

skip newstestsTests in the Lib/test dirtopic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@savannahostrowski@hugovk@erlend-aasland@FFY00@brandtbucher@AlexWaygood