Skip to content

gh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files. - #120435

Merged
hugovk merged 23 commits into
python:mainfrom
Eclips4:issue-119146
Jun 13, 2024
Merged

gh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files.#120435
hugovk merged 23 commits into
python:mainfrom
Eclips4:issue-119146

Conversation

@Eclips4

@Eclips4Eclips4 commented Jun 12, 2024•
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-appbedevere-appBot mentioned this pull request Jun 12, 2024
Closed
@Eclips4
Eclips4 marked this pull request as draft June 12, 2024 20:09
@Eclips4Eclips4 mentioned this pull request Jun 12, 2024
Merged
@Eclips4

Eclips4 commented Jun 12, 2024

Copy link
Copy Markdown
MemberAuthor

@hugovk
So, these wildcard patterns actually work and the jit workflow is skipped, but other workflows don't take these exceptions into account.

@Eclips4Eclips4 changed the title gh-119146: Move wildcard patterns to topgh-119146: Update regexp in build.yml to not trigger the jobs on *.md and *.ini files.Jun 12, 2024
@Eclips4Eclips4 added the needs backport to 3.13 bugs and security fixes label Jun 12, 2024
savannahostrowski
savannahostrowski approved these changes Jun 13, 2024
View reviewed changes

@savannahostrowskisavannahostrowski left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit messages are so relatable 😅 . Testing GHA workflows is always such a pain. This LGTM!

hugovk
hugovk reviewed Jun 13, 2024
View reviewed changes
Comment thread.github/workflows/build.yml Outdated
@Eclips4@hugovk
Update .github/workflows/build.yml
8a799d7
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
hugovk approved these changes Jun 13, 2024
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Shall we also backport to 3.12?

@hugovk
hugovk merged commit ca5108a into python:mainJun 13, 2024
@miss-islington-app

miss-islington-appBot commented Jun 13, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2024
@Eclips4@hugovk@miss-islington
pythongh-119146: Updateregexpinbuild.ymlto not trigger the …
e5c5ce6
…jobs on `*.md` and `*.ini` files. (pythonGH-120435)
(cherry picked from commit ca5108a)
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jun 13, 2024

Copy link
Copy Markdown

GH-120447 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Jun 13, 2024
hugovk added a commit that referenced this pull request Jun 13, 2024
@miss-islington@Eclips4@hugovk
[3.13]gh-119146: Updateregexpinbuild.ymlto not trigger the…
5ce72e2
… jobs on `*.md` and `*.ini` files. (GH-120435) (#120447)
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Eclips4

Eclips4 commented Jun 13, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks! Shall we also backport to 3.12?

I think yes. #119147 wasn't backported to 3.12 because it was related to JIT workflow which appeared only in 3.13.
This PR does a more generally thing, so I think it would be ok to backport it to 3.12.

@Eclips4Eclips4 added the needs backport to 3.12 only security fixes label Jun 13, 2024
@miss-islington-app

miss-islington-appBot commented Jun 13, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2024
@Eclips4@hugovk@miss-islington
pythongh-119146: Updateregexpinbuild.ymlto not trigger the …
a71011a
…jobs on `*.md` and `*.ini` files. (pythonGH-120435)
(cherry picked from commit ca5108a)
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Jun 13, 2024

Copy link
Copy Markdown

GH-120448 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.12 only security fixes label Jun 13, 2024
hugovk added a commit that referenced this pull request Jun 13, 2024
@miss-islington@Eclips4@hugovk
[3.12]gh-119146: Updateregexpinbuild.ymlto not trigger the…
f8dd4c3
… jobs on `*.md` and `*.ini` files. (GH-120435) (#120448)
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@Eclips4
Eclips4 deleted the issue-119146 branch June 13, 2024 12:39
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@Eclips4@hugovk@mrahtz
pythongh-119146: Updateregexpinbuild.ymlto not trigger the …
6ecd9b3
…jobs on `*.md` and `*.ini` files. (python#120435)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Eclips4@hugovk@noahbkim
pythongh-119146: Updateregexpinbuild.ymlto not trigger the …
9afc3bc
…jobs on `*.md` and `*.ini` files. (python#120435)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4@hugovk@estyxx
pythongh-119146: Updateregexpinbuild.ymlto not trigger the …
ce3b16a
…jobs on `*.md` and `*.ini` files. (python#120435)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@AA-TurnerAA-Turner mentioned this pull request Feb 3, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@savannahostrowskisavannahostrowskisavannahostrowski approved these changes
@brandtbucherbrandtbucherAwaiting requested review from brandtbucher
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eclips4@hugovk@savannahostrowski