Skip to content

CI: set correct working directory for Hypothesis cache - #119345

Merged
encukou merged 1 commit into
python:mainfrom
Zac-HD:zac/fix-hypothesis-ci-caching
May 29, 2024
Merged

CI: set correct working directory for Hypothesis cache#119345
encukou merged 1 commit into
python:mainfrom
Zac-HD:zac/fix-hypothesis-ci-caching

Conversation

@Zac-HD

@Zac-HDZac-HD commented May 21, 2024

Copy link
Copy Markdown
Contributor

I noticed when pairing with @encukou that this cache logic never found any files to upload (nor restore).

This isn't a huge problem, but ensuring that we replay any known failing examples on your branch is a nicer developer experience, made possible by persisting the cache between runs.

@Zac-HDZac-HD mentioned this pull request May 22, 2024
Open
encukou
encukou previously approved these changes May 22, 2024
View reviewed changes
@encukou
encukou enabled auto-merge (squash) May 22, 2024 14:30
auto-merge was automatically disabled May 22, 2024 16:33

Head branch was pushed to by a user without write access

@Zac-HD
Zac-HDforce-pushed the zac/fix-hypothesis-ci-caching branch from 791c418 to 219de60CompareMay 22, 2024 16:33
@Zac-HD
Zac-HD marked this pull request as draft May 22, 2024 16:54
@Zac-HD

Zac-HD commented May 22, 2024

Copy link
Copy Markdown
ContributorAuthor

Marking as draft; I'll mark ready-for-review once I see a build which successfully uploaded the cache and artifact.

@encukou

encukou commented May 22, 2024

Copy link
Copy Markdown
Member

GitHub might be using the main branch's actions rather than those from this PR.
One workaround is to enable actions on your fork, and open a PR against that.

@Zac-HD
Zac-HDforce-pushed the zac/fix-hypothesis-ci-caching branch from 219de60 to 3a51825CompareMay 23, 2024 18:56
@encukou
encukou dismissed their stale reviewMay 23, 2024 19:23

Experiments are going on

@Zac-HD
Zac-HDforce-pushed the zac/fix-hypothesis-ci-caching branch from 083f0eb to dbfb2e6CompareMay 26, 2024 22:24
@Zac-HD
Zac-HD marked this pull request as ready for review May 26, 2024 22:33
@Zac-HD

Zac-HD commented May 26, 2024

Copy link
Copy Markdown
ContributorAuthor

@encukou got it! The problem was that Regrtest switches to a tempdir, so I also needed to configure Hypothesis to use the original working dir for the database. With that in place, the cache is working and the artifact upload is (correctly) skipped when no tests failed.

@encukou

encukou commented May 29, 2024

Copy link
Copy Markdown
Member

Thanks!

@encukou
encukou merged commit 055c739 into python:mainMay 29, 2024
@Zac-HD
Zac-HD deleted the zac/fix-hypothesis-ci-caching branch May 29, 2024 15:57
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Zac-HD@noahbkim
CI: set correct working directory for Hypothesis cache (pythonGH-119345)
7b4ce61
Set cwd for Hypothesis database
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Zac-HD@estyxx
CI: set correct working directory for Hypothesis cache (pythonGH-119345)
8a295d0
Set cwd for Hypothesis database
@sobolevnsobolevn added the needs backport to 3.13 bugs and security fixes label Apr 10, 2025
@miss-islington-app

miss-islington-appBot commented Apr 10, 2025

Copy link
Copy Markdown

Thanks @Zac-HD for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2025
@Zac-HD@miss-islington
CI: set correct working directory for Hypothesis cache (pythonGH-119345)
09a7e32
Set cwd for Hypothesis database
(cherry picked from commit 055c739)
Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
@bedevere-app

bedevere-appBot commented Apr 10, 2025

Copy link
Copy Markdown

GH-132364 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 10, 2025
@sobolevn

sobolevn commented Apr 10, 2025

Copy link
Copy Markdown
Member

See #132348 on why we backport this.

sobolevn pushed a commit that referenced this pull request Apr 10, 2025
@miss-islington@Zac-HD
[3.13] CI: set correct working directory for Hypothesis cache (GH-119345
ce92107
) (#132364)
CI: set correct working directory for Hypothesis cache (GH-119345)
Set cwd for Hypothesis database
(cherry picked from commit 055c739)
Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments
@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner
@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

No one assigned

Labels

skip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zac-HD@encukou@sobolevn