Skip to content

gh-132316: Require socket and GITHUB_TOKEN env to use GitHubArtifactDatabase - #132348

Merged
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-132316
Apr 10, 2025
Merged

gh-132316: Require socket and GITHUB_TOKEN env to use GitHubArtifactDatabase#132348
sobolevn merged 2 commits into
python:mainfrom
sobolevn:issue-132316

Conversation

@sobolevn

@sobolevnsobolevn commented Apr 10, 2025•
edited
Loading

Copy link
Copy Markdown
Member

I did not check for enabled resources, because this is a local build.

@sobolevn
sobolevn requested review from hugovk and vstinnerApril 10, 2025 07:35
@bedevere-appbedevere-appBot mentioned this pull request Apr 10, 2025
Closed
hugovk
hugovk approved these changes Apr 10, 2025
View reviewed changes
Comment threadLib/test/support/hypothesis_helper.py Outdated
@sobolevn@hugovk
Update Lib/test/support/hypothesis_helper.py
5a18efa
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@sobolevn
sobolevn merged commit fcf2d07 into python:mainApr 10, 2025
@miss-islington-app

miss-islington-appBot commented Apr 10, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-appBot commented Apr 10, 2025

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fcf2d07228ada64bc864380cd8e3e304d9768caa 3.13

@sobolevn

sobolevn commented Apr 10, 2025

Copy link
Copy Markdown
MemberAuthor

@hugovk do I need to backport this? Since 055c739 was not backported?

@hugovk

hugovk commented Apr 10, 2025

Copy link
Copy Markdown
Member

Let's skip it if not needed. It can always be updated later.

@hugovkhugovk removed the needs backport to 3.13 bugs and security fixes label Apr 10, 2025
@kulikjak

kulikjak commented Apr 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

I wouldn't mind getting this backported into 3.13 since that is the version we found it in :). But we can certainly vendor the patch if necessary.

@sobolevn

sobolevn commented Apr 10, 2025

Copy link
Copy Markdown
MemberAuthor

@hugovk let's then backport both PRs maybe?

@hugovk

hugovk commented Apr 10, 2025

Copy link
Copy Markdown
Member

Sure! Can you take care of it?

@sobolevn

sobolevn commented Apr 10, 2025

Copy link
Copy Markdown
MemberAuthor

Will do :)

This was referenced Apr 10, 2025
Merged
Merged
@sobolevnsobolevn added the needs backport to 3.13 bugs and security fixes label Apr 10, 2025
@miss-islington-app

miss-islington-appBot commented Apr 10, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2025
@sobolevn@hugovk@miss-islington
pythongh-132316: RequiresocketandGITHUB_TOKENenv to use `GitH…
f682e9e
…ubArtifactDatabase` (pythonGH-132348)
(cherry picked from commit fcf2d07)
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-appBot commented Apr 10, 2025

Copy link
Copy Markdown

GH-132367 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appBot removed the needs backport to 3.13 bugs and security fixes label Apr 10, 2025
sobolevn added a commit that referenced this pull request Apr 10, 2025
@miss-islington@sobolevn@hugovk
[3.13]gh-132316: RequiresocketandGITHUB_TOKENenv to use `Git…
2b61f6a
…HubArtifactDatabase` (GH-132348) (#132367)
gh-132316: Require `socket` and `GITHUB_TOKEN` env to use `GitHubArtifactDatabase` (GH-132348)
(cherry picked from commit fcf2d07)
Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@kulikjak

kulikjak commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

Thanks @sobolevn! Tests with latest 3.13 bits are green again.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

@sobolevnsobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@hugovk@kulikjak