Uh oh!
There was an error while loading. Please reload this page.
gh-118934: Make PyEval_GetLocals return borrowed reference - #119769
Conversation
gaogaotiantian
commented
May 30, 2024
Just realized this will overwrite |
colesbury
left a comment
There was a problem hiding this comment.
A few formatting suggestions and a question about the return value
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ncoghlan
commented
Jul 16, 2024
@gaogaotiantian I merged the suggestion that reverts back to the Python 3.12 semantics, so we can get a CI run on that version of the refleak fix. |
ncoghlan
left a comment
There was a problem hiding this comment.
@gaogaotiantian CI is happy with going back to the Python 3.12 behaviour, so if you're happy I think this is good to merge for the final beta.
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…honGH-119769) (cherry picked from commit e65cb4c) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com> Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
GH-121869 is a backport of this pull request to the 3.13 branch. |
bedevere-bot
commented
Jul 18, 2024
|
bedevere-bot
commented
Jul 18, 2024
|
Per discussion with @markshannon in Pittsburgh, we simulate what we did pre-PEP667. We store the locals dict in
frame->f_localsso that we can return a borrowed reference. Theframe->f_localswill be cleared when the frame is released. This way we can keep the behavior ofPyEval_GetLocals().PyEval_GetLocals()leaks locals #118934