Skip to content

PEP 667: Clarify impact on PyEval_GetLocals - #3809

Closed
ncoghlan wants to merge 6 commits into
python:mainfrom
ncoghlan:pep-667-clarify-pyeval_getlocals
Closed

PEP 667: Clarify impact on PyEval_GetLocals#3809
ncoghlan wants to merge 6 commits into
python:mainfrom
ncoghlan:pep-667-clarify-pyeval_getlocals

Conversation

@ncoghlan

@ncoghlanncoghlan commented Jun 2, 2024

Copy link
Copy Markdown
Contributor

See Implementation Notes in the updated PEP for details of the correction/clarification and the rationale for it.

The discrepancy was detected when writing the documentation for python/cpython#74929 and when reviewing python/cpython#118934

  • Change is:
    • To an Accepted or Final PEP, with Steering Council approval
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--3809.org.readthedocs.build/

See Implementation Notes in the updated PEP for details
of the correction/clarification and the rationale for it.
The discrepancy was detected when writing the documentation for
python/cpython#74929 and when reviewing
python/cpython#118934
@ncoghlan
ncoghlan marked this pull request as draft June 3, 2024 16:20
@ncoghlan

Copy link
Copy Markdown
ContributorAuthor

Converted to draft, as the discussion on python/cpython#119769 makes it clear the end state for the PyEval_GetLocals() semantics isn't actually certain yet.

@ncoghlan

Copy link
Copy Markdown
ContributorAuthor

Request to the SC posted to ask for help in choosing the semantics implemented for PyEval_GetLocals in 3.13+: python/steering-council#245 (comment)

@ncoghlan
ncoghlan marked this pull request as ready for review June 21, 2024 15:39
@ncoghlan

Copy link
Copy Markdown
ContributorAuthor

SC has confirmed that PyEval_GetLocals should retain its 3.12 behaviour: python/steering-council#245 (comment)

Comment threadpeps/pep-0667.rst Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@ncoghlan

Copy link
Copy Markdown
ContributorAuthor

I am combining this PR with the one clarifying the Python API changes in #3845 rather than keeping them separate.

@ncoghlan
ncoghlan deleted the pep-667-clarify-pyeval_getlocals branch July 4, 2024 02:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ncoghlan@JelleZijlstra