Uh oh!
There was an error while loading. Please reload this page.
gh-118934: Fix PyEval_GetLocals docs (PEP 667) - #119932
Merged
ncoghlan merged 4 commits intoJun 2, 2024
Merged
Conversation
PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added for pythongh-74929 didn't match either the current behaviour or the intended behaviour once pythongh-118934 is fixed. This PR updates the documentation and 3.13 What's New to match the intended behaviour (once pythongh-118934 is fixed).
ncoghlan
enabled auto-merge (squash)
June 2, 2024 04:33
ncoghlan
commented
Jun 2, 2024
ContributorAuthor
Set to auto-merge, since I don't want to risk the currently incorrect docs making their way into beta2 this week. |
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @ncoghlan, I could not cleanly backport this to |
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 2, 2024
PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added for pythongh-74929 didn't match either the current behaviour or the intended behaviour once pythongh-118934 is fixed. This PR updates the documentation and 3.13 What's New to match the intended behaviour (once pythongh-118934 is fixed). It also tidies up lingering references to `f_locals` always being a dictionary (this hasn't been true since at least when custom namespace support for class statement execution was added) (cherry picked from commit fd6cd62) Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
GH-119934 is a backport of this pull request to the 3.13 branch. |
ncoghlan
commented
Jun 2, 2024
ContributorAuthor
Conflict was due to my failure to merge #119894 yesterday. Fixed that, and retriggered miss-islington |
barneygale pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added for pythongh-74929 didn't match either the current behaviour or the intended behaviour once pythongh-118934 is fixed. This PR updates the documentation and 3.13 What's New to match the intended behaviour (once pythongh-118934 is fixed). It also tidies up lingering references to `f_locals` always being a dictionary (this hasn't been true since at least when custom namespace support for class statement execution was added)
noahbkim pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added for pythongh-74929 didn't match either the current behaviour or the intended behaviour once pythongh-118934 is fixed. This PR updates the documentation and 3.13 What's New to match the intended behaviour (once pythongh-118934 is fixed). It also tidies up lingering references to `f_locals` always being a dictionary (this hasn't been true since at least when custom namespace support for class statement execution was added)
estyxx pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added for pythongh-74929 didn't match either the current behaviour or the intended behaviour once pythongh-118934 is fixed. This PR updates the documentation and 3.13 What's New to match the intended behaviour (once pythongh-118934 is fixed). It also tidies up lingering references to `f_locals` always being a dictionary (this hasn't been true since at least when custom namespace support for class statement execution was added)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 667's description of the planned changes to PyEval_GetLocals was internally inconsistent when accepted, so the docs added for gh-74929 didn't match either the current behaviour or the intended behaviour once gh-118934 is fixed.
This PR updates the documentation and 3.13 What's New to match the intended behaviour (once gh-118934 is fixed).
📚 Documentation preview 📚: https://cpython-previews--119932.org.readthedocs.build/