Uh oh!
There was an error while loading. Please reload this page.
gh-121832: Skip subinterpreter static type check on iOS to restore test suite. - #122150
Merged
Conversation
freakboy3742
commented
Jul 23, 2024
ContributorAuthor
!buildbot iOS |
bedevere-bot
commented
Jul 23, 2024
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit e92cada 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
markshannon
approved these changes
Jul 23, 2024
markshannon
left a comment
Member
There was a problem hiding this comment.
Thanks @freakboy3742 for unblocking this.
Thanks @freakboy3742 for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2024
…ore test suite. (pythonGH-122150) (cherry picked from commit 1bcc9eb) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
GH-122159 is a backport of this pull request to the 3.13 branch. |
nohlson pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
nohlson pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
freakboy3742 added a commit
to freakboy3742/cpython
that referenced
this pull request
Jul 27, 2024
freakboy3742 added a commit
that referenced
this pull request
Jul 27, 2024
freakboy3742 added a commit
to freakboy3742/cpython
that referenced
this pull request
Jul 27, 2024
… (pythonGH-122340) Revert test skip introduced by pythonGH-122150. (cherry picked from commit 863a92f) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit
that referenced
this pull request
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPython test suite will crash if you run any test that creates a subinterpreter after running the
test_type_cachetest.This bug affects all platforms; but iOS is the only platform that reliably hits the bug as part of test suite execution, as it is the only platform that runs the test suite in a single process.
test_typesis the only test that creates a subinterpreter aftertest_type_cache. This PR skips the subinterpreter slot tests that are part oftest_typeson iOS as a temporary measure so that we can observe other failures that might be occurring in iOS.When a final fix for #121832 is in place, this test skip can be removed.
--with-pydebugenabled #121832